core/include/fxge/fx_dib.h - Issue 578253002: Add missing parenthesis in FXARGB_GETDIB macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fxge/fx_dib.h

Issue 578253002: Add missing parenthesis in FXARGB_GETDIB macro (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fxge/fx_dib.h

diff --git a/core/include/fxge/fx_dib.h b/core/include/fxge/fx_dib.h

index 957a95704324d06a2b1b11b9b1cebc7fae4e3fdb..d8a2003548c8bee1739405ab79e62a056390554c 100644

--- a/core/include/fxge/fx_dib.h

+++ b/core/include/fxge/fx_dib.h

@@ -105,7 +105,7 @@ FX_ARGB ArgbEncode(int a, FX_COLORREF rgb);

((FX_LPBYTE)(p))[1] = (FX_BYTE)((cmyk) >> 16), \

((FX_LPBYTE)(p))[2] = (FX_BYTE)((cmyk) >> 8), \

((FX_LPBYTE)(p))[3] = (FX_BYTE)(cmyk))

-#define FXARGB_GETDIB(p) (((FX_LPBYTE)(p))[0]) | (((FX_LPBYTE)(p))[1] << 8) | (((FX_LPBYTE)(p))[2] << 16) | (((FX_LPBYTE)(p))[3] << 24)

+#define FXARGB_GETDIB(p) ((((FX_LPBYTE)(p))[0]) | (((FX_LPBYTE)(p))[1] << 8) | (((FX_LPBYTE)(p))[2] << 16) | (((FX_LPBYTE)(p))[3] << 24))

#define FXARGB_SETDIB(p, argb) ((FX_LPBYTE)(p))[0] = (FX_BYTE)(argb), \

((FX_LPBYTE)(p))[1] = (FX_BYTE)((argb) >> 8), \

((FX_LPBYTE)(p))[2] = (FX_BYTE)((argb) >> 16), \

« no previous file with comments | « no previous file | no next file » | no next file with comments »