Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: Source/build/scripts/make_css_value_keywords.py

Issue 57813007: CSS property names and value keywords no longer requires conditions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/build/scripts/make_css_property_names.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/build/scripts/make_css_value_keywords.py
diff --git a/Source/build/scripts/make_css_value_keywords.py b/Source/build/scripts/make_css_value_keywords.py
index cb7e7c1c55e11a6fb2d2ef4e67d178c0061767c3..e242d71cff3543a1145f684591cb775a078ec08e 100755
--- a/Source/build/scripts/make_css_value_keywords.py
+++ b/Source/build/scripts/make_css_value_keywords.py
@@ -107,7 +107,6 @@ bool isValueAllowedInMode(unsigned short id, CSSParserMode mode)
class CSSValueKeywordsWriter(in_generator.Writer):
class_name = "CSSValueKeywords"
defaults = {
- 'condition': None,
'mode': None,
}
@@ -117,8 +116,7 @@ class CSSValueKeywordsWriter(in_generator.Writer):
(self.class_name + ".cpp"): self.generate_implementation,
}
- all_properties = self.in_file.name_dictionaries
- self._value_keywords = filter(lambda property: not property['condition'] or property['condition'] in self._enabled_conditions, all_properties)
Julien - ping for review 2013/11/07 23:41:53 I think those where the only users of _enabled_con
+ self._value_keywords = self.in_file.name_dictionaries
first_property_id = 1
for offset, property in enumerate(self._value_keywords):
property['name'] = property['name'].lower()
« no previous file with comments | « Source/build/scripts/make_css_property_names.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698