Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: Source/build/scripts/make_css_property_names.py

Issue 57813007: CSS property names and value keywords no longer requires conditions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/build/scripts/make_css_property_names.py
diff --git a/Source/build/scripts/make_css_property_names.py b/Source/build/scripts/make_css_property_names.py
index ec5d47a454c6052bdb5442218e5fbeab2eb00fac..b4822b1b26e8d301f7439bd739a71140c44e9981 100755
--- a/Source/build/scripts/make_css_property_names.py
+++ b/Source/build/scripts/make_css_property_names.py
@@ -183,7 +183,6 @@ class CSSPropertiesWriter(in_generator.Writer):
class_name = "CSSPropertyNames"
defaults = {
'alias_for': None,
- 'condition': None,
'is_internal': False,
}
@@ -193,14 +192,13 @@ class CSSPropertiesWriter(in_generator.Writer):
(self.class_name + ".cpp"): self.generate_implementation,
}
- all_properties = self.in_file.name_dictionaries
- self._aliases = filter(lambda property: property['alias_for'], all_properties)
+ self._aliases = filter(lambda property: property['alias_for'], self.in_file.name_dictionaries)
for offset, property in enumerate(self._aliases):
# Aliases use the enum_name that they are an alias for.
property['enum_name'] = self._enum_name_from_property_name(property['alias_for'])
# Aliases do not get an enum_value.
- self._properties = filter(lambda property: not property['alias_for'] and not property['condition'] or property['condition'] in self._enabled_conditions, all_properties)
+ self._properties = filter(lambda property: not property['alias_for'], self.in_file.name_dictionaries)
if len(self._properties) > 1024:
print "ERROR : There is more than 1024 CSS Properties, you need to update CSSProperty.h/StylePropertyMetadata m_propertyID accordingly."
exit(1)
« no previous file with comments | « no previous file | Source/build/scripts/make_css_value_keywords.py » ('j') | Source/build/scripts/make_css_value_keywords.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698