Issue 57813007: CSS property names and value keywords no longer requires conditions

Issue 57813007: CSS property names and value keywords no longer requires conditions (Closed)

Created:
7 years, 1 month ago by abinader

Modified:
7 years, 1 month ago

Reviewers:
keishi, Julien - ping for review, eseidel

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

We no longer have CSS property names neither value keywords depending on compile flag conditions, thus we can safely remove its support. BUG=314055 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161868

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Julien's review on removing enabled_conditions param #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -56 lines)			Patch
M	Source/build/scripts/in_generator.py	View	1	3 chunks	+2 lines, -25 lines	0 comments	Download
M	Source/build/scripts/make_css_property_names.py	View	1	1 chunk	+4 lines, -6 lines	0 comments	Download
M	Source/build/scripts/make_css_value_keywords.py	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
M	Source/build/scripts/make_element_factory.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/build/scripts/make_event_factory.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/build/scripts/make_internal_runtime_flags.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/build/scripts/make_names.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/build/scripts/make_qualified_names.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/build/scripts/make_runtime_features.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/build/scripts/make_settings.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/build/scripts/make_style_builder.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/build/scripts/make_style_shorthands.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/build/scripts/name_macros.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

keishi

On 2013/11/06 21:16:48, abinader wrote: lgtm for make_css_value_keywords.py

7 years, 1 month ago (2013-11-07 02:10:43 UTC) #2

Julien - ping for review

https://codereview.chromium.org/57813007/diff/160001/Source/build/scripts/make_css_value_keywords.py File Source/build/scripts/make_css_value_keywords.py (left): https://codereview.chromium.org/57813007/diff/160001/Source/build/scripts/make_css_value_keywords.py#oldcode121 Source/build/scripts/make_css_value_keywords.py:121: self._value_keywords = filter(lambda property: not property['condition'] or property['condition'] in ...

7 years, 1 month ago (2013-11-07 23:41:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruno.d@partner.samsung.com/57813007/250001

7 years, 1 month ago (2013-11-11 14:32:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruno.d@partner.samsung.com/57813007/250001

7 years, 1 month ago (2013-11-13 01:21:17 UTC) #5

Message was sent while issue was closed.

Change committed as 161868

Expand Messages | Collapse Messages