Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: Source/build/scripts/make_css_property_names.py

Issue 57813007: CSS property names and value keywords no longer requires conditions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Julien's review on removing enabled_conditions param Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/build/scripts/in_generator.py ('k') | Source/build/scripts/make_css_value_keywords.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/build/scripts/make_css_property_names.py
diff --git a/Source/build/scripts/make_css_property_names.py b/Source/build/scripts/make_css_property_names.py
index ec5d47a454c6052bdb5442218e5fbeab2eb00fac..b5deb2732cf6a70bc718f0a9aa9f4071b710f932 100755
--- a/Source/build/scripts/make_css_property_names.py
+++ b/Source/build/scripts/make_css_property_names.py
@@ -183,24 +183,22 @@ class CSSPropertiesWriter(in_generator.Writer):
class_name = "CSSPropertyNames"
defaults = {
'alias_for': None,
- 'condition': None,
'is_internal': False,
}
- def __init__(self, file_paths, enabled_conditions):
- in_generator.Writer.__init__(self, file_paths, enabled_conditions)
+ def __init__(self, file_paths):
+ in_generator.Writer.__init__(self, file_paths)
self._outputs = {(self.class_name + ".h"): self.generate_header,
(self.class_name + ".cpp"): self.generate_implementation,
}
- all_properties = self.in_file.name_dictionaries
- self._aliases = filter(lambda property: property['alias_for'], all_properties)
+ self._aliases = filter(lambda property: property['alias_for'], self.in_file.name_dictionaries)
for offset, property in enumerate(self._aliases):
# Aliases use the enum_name that they are an alias for.
property['enum_name'] = self._enum_name_from_property_name(property['alias_for'])
# Aliases do not get an enum_value.
- self._properties = filter(lambda property: not property['alias_for'] and not property['condition'] or property['condition'] in self._enabled_conditions, all_properties)
+ self._properties = filter(lambda property: not property['alias_for'], self.in_file.name_dictionaries)
if len(self._properties) > 1024:
print "ERROR : There is more than 1024 CSS Properties, you need to update CSSProperty.h/StylePropertyMetadata m_propertyID accordingly."
exit(1)
« no previous file with comments | « Source/build/scripts/in_generator.py ('k') | Source/build/scripts/make_css_value_keywords.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698