Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 57813003: Reland: Convert ExtensionProcessManager to BrowserContext, part 1 (Closed)

Created:
7 years, 1 month ago by James Cook
Modified:
7 years, 1 month ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Reland: Convert ExtensionProcessManager to BrowserContext, part 1 Reland of https://codereview.chromium.org/52983004/ which failed due to timeouts on Windows XP. Part of moving ExtensionProcessManager to src/extensions. * Introduce more test coverage * Convert most usage of Profile to BrowserContext * Separate out "master" vs. incognito profiles/contexts * Move switches into extensions/common/switches.h BUG=313481 TEST=unit_tests ExtensionProcessManager* and browser_tests ExtensionProcessManager* TBR=miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232904

Patch Set 1 #

Patch Set 2 : split test, add logs #

Patch Set 3 : disable on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -127 lines) Patch
M chrome/browser/apps/app_browsertest_util.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.h View 7 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 27 chunks +104 lines, -87 lines 0 comments Download
A chrome/browser/extensions/extension_process_manager_browsertest.cc View 1 2 1 chunk +111 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager_unittest.cc View 3 chunks +84 lines, -3 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/notifications_apitest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M extensions/browser/extensions_browser_client.h View 2 chunks +10 lines, -1 line 0 comments Download
M extensions/browser/lazy_background_task_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/switches.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/57813003/70001
7 years, 1 month ago (2013-11-04 18:44:28 UTC) #1
miket_OOO
On 2013/11/04 18:44:28, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 1 month ago (2013-11-04 18:45:38 UTC) #2
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97403
7 years, 1 month ago (2013-11-04 22:44:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/57813003/70001
7 years, 1 month ago (2013-11-05 00:28:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/57813003/70001
7 years, 1 month ago (2013-11-05 03:26:01 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 04:26:22 UTC) #6
Message was sent while issue was closed. 
Change committed as 232904

Powered by Google App Engine
This is Rietveld 408576698