Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Unified Diff: chrome/browser/extensions/extension_process_manager_unittest.cc

Issue 57813003: Reland: Convert ExtensionProcessManager to BrowserContext, part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: disable on windows Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_process_manager_unittest.cc
diff --git a/chrome/browser/extensions/extension_process_manager_unittest.cc b/chrome/browser/extensions/extension_process_manager_unittest.cc
index bdd8d964b9507a00d84faf743f0e37c6769f9ae5..70a01f8516449cc1516c74796e63b567041e6b13 100644
--- a/chrome/browser/extensions/extension_process_manager_unittest.cc
+++ b/chrome/browser/extensions/extension_process_manager_unittest.cc
@@ -3,8 +3,11 @@
// found in the LICENSE file.
#include "chrome/browser/extensions/extension_process_manager.h"
+
+#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/extension_error_reporter.h"
#include "chrome/test/base/testing_profile.h"
+#include "content/public/browser/notification_service.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/site_instance.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -12,8 +15,6 @@
using content::SiteInstance;
-namespace {
-
// make the test a PlatformTest to setup autorelease pools properly on mac
class ExtensionProcessManagerTest : public testing::Test {
public:
@@ -24,9 +25,89 @@ class ExtensionProcessManagerTest : public testing::Test {
virtual void SetUp() {
ExtensionErrorReporter::GetInstance()->ClearErrors();
}
+
+ // Returns true if the notification |type| is registered for |manager| with
+ // source |profile|. Pass NULL for |profile| for all sources.
+ static bool IsRegistered(ExtensionProcessManager* manager,
+ int type,
+ TestingProfile* profile) {
+ return manager->registrar_.IsRegistered(
+ manager, type, content::Source<Profile>(profile));
+ }
+
+ // Allows access to a protected method.
+ static Profile* GetProfile(ExtensionProcessManager* manager) {
+ return manager->GetProfile();
+ }
};
-} // namespace
+// Test that notification registration works properly.
+TEST_F(ExtensionProcessManagerTest, ExtensionNotificationRegistration) {
+ // Test for a normal profile.
+ scoped_ptr<TestingProfile> original_profile(new TestingProfile);
+ scoped_ptr<ExtensionProcessManager> manager1(
+ ExtensionProcessManager::Create(original_profile.get()));
+
+ EXPECT_EQ(original_profile.get(), GetProfile(manager1.get()));
+ EXPECT_EQ(0u, manager1->background_hosts().size());
+
+ // It observes some notifications from all sources.
+ EXPECT_TRUE(IsRegistered(
+ manager1.get(), chrome::NOTIFICATION_BROWSER_WINDOW_READY, NULL));
+
+ // It observes other notifications from this profile.
+ EXPECT_TRUE(IsRegistered(manager1.get(),
+ chrome::NOTIFICATION_EXTENSIONS_READY,
+ original_profile.get()));
+ EXPECT_TRUE(IsRegistered(manager1.get(),
+ chrome::NOTIFICATION_EXTENSION_LOADED,
+ original_profile.get()));
+ EXPECT_TRUE(IsRegistered(manager1.get(),
+ chrome::NOTIFICATION_EXTENSION_UNLOADED,
+ original_profile.get()));
+ EXPECT_TRUE(IsRegistered(manager1.get(),
+ chrome::NOTIFICATION_EXTENSION_HOST_DESTROYED,
+ original_profile.get()));
+
+ // Now add an incognito profile associated with the master above.
+ TestingProfile::Builder builder;
+ builder.SetIncognito();
+ scoped_ptr<TestingProfile> incognito_profile = builder.Build();
+ incognito_profile->SetOriginalProfile(original_profile.get());
+ scoped_ptr<ExtensionProcessManager> manager2(
+ ExtensionProcessManager::Create(incognito_profile.get()));
+
+ EXPECT_EQ(incognito_profile.get(), GetProfile(manager2.get()));
+ EXPECT_EQ(0u, manager2->background_hosts().size());
+
+ // Some notifications are observed for the original profile.
+ EXPECT_TRUE(IsRegistered(manager2.get(),
+ chrome::NOTIFICATION_EXTENSION_LOADED,
+ original_profile.get()));
+
+ // Some notifications are observed for the incognito profile.
+ EXPECT_TRUE(IsRegistered(manager2.get(),
+ chrome::NOTIFICATION_EXTENSION_HOST_DESTROYED,
+ incognito_profile.get()));
+
+ // Some notifications are observed for both incognito and original.
+ EXPECT_TRUE(IsRegistered(manager2.get(),
+ chrome::NOTIFICATION_PROFILE_DESTROYED,
+ original_profile.get()));
+ EXPECT_TRUE(IsRegistered(manager2.get(),
+ chrome::NOTIFICATION_PROFILE_DESTROYED,
+ incognito_profile.get()));
+
+ // Some are not observed at all.
+ EXPECT_FALSE(IsRegistered(manager2.get(),
+ chrome::NOTIFICATION_EXTENSIONS_READY,
+ original_profile.get()));
+
+ // This notification is observed for incognito profiles only.
+ EXPECT_TRUE(IsRegistered(manager2.get(),
+ chrome::NOTIFICATION_PROFILE_DESTROYED,
+ incognito_profile.get()));
+}
// Test that extensions get grouped in the right SiteInstance (and therefore
// process) based on their URLs.

Powered by Google App Engine
This is Rietveld 408576698