src/globals.h - Issue 577973002: ES6: Implement generator method shorthand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/globals.h

Issue 577973002: ES6: Implement generator method shorthand (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: cleanup Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/globals.h

diff --git a/src/globals.h b/src/globals.h

index 55bb57289d9018f35d9bf78037230556bae7ea50..75c131945497ccbc7080e56d80583550c4721dd5 100644

--- a/src/globals.h

+++ b/src/globals.h

@@ -771,7 +771,9 @@ inline bool IsValidFunctionKind(FunctionKind kind) {

return kind == FunctionKind::kNormalFunction ||

kind == FunctionKind::kArrowFunction ||

kind == FunctionKind::kGeneratorFunction ||

- kind == FunctionKind::kConciseMethod;

+ kind == FunctionKind::kConciseMethod ||

+ kind ==

+ (FunctionKind::kGeneratorFunction | FunctionKind::kConciseMethod);

Dmitry Lomov (no reviews) 2014/09/18 07:43:57 The comment in this function is now obsolete.

arv (Not doing code reviews) 2014/09/18 15:59:02 Done.

}

« no previous file with comments | « no previous file | src/preparser.h » ('j') | src/preparser.h » ('J')