ES6: Implement generator method shorthand

src/globals.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_GLOBALS_H_
 #define V8_GLOBALS_H_
 
 #include "include/v8stdint.h"
 
 #include "src/base/build_config.h"
@@ skipping 753 matching lines @@
   kConciseMethod = 4
 };
 
 
 inline bool IsValidFunctionKind(FunctionKind kind) {
   // At the moment these are mutually exclusive but in the future that wont be
   // the case since ES6 allows concise generator methods.
   return kind == FunctionKind::kNormalFunction ||
          kind == FunctionKind::kArrowFunction ||
          kind == FunctionKind::kGeneratorFunction ||
-         kind == FunctionKind::kConciseMethod;
+         kind == FunctionKind::kConciseMethod ||
+         kind ==
+             (FunctionKind::kGeneratorFunction | FunctionKind::kConciseMethod);

[Dmitry Lomov (no reviews), 2014/09/18 07:43:57]

The comment in this function is now obsolete.

[arv (Not doing code reviews), 2014/09/18 15:59:02]

Done.

 }
 
 
 inline bool IsArrowFunction(FunctionKind kind) {
   DCHECK(IsValidFunctionKind(kind));
   return kind & FunctionKind::kArrowFunction;
 }
 
 
 inline bool IsGeneratorFunction(FunctionKind kind) {
   DCHECK(IsValidFunctionKind(kind));
   return kind & FunctionKind::kGeneratorFunction;
 }
 
 
 inline bool IsConciseMethod(FunctionKind kind) {
   DCHECK(IsValidFunctionKind(kind));
   return kind & FunctionKind::kConciseMethod;
 }
 } }  // namespace v8::internal
 
 namespace i = v8::internal;
 
 #endif  // V8_GLOBALS_H_