ES6: Implement generator method shorthand

ES6: Implement generator method shorthand

https://people.mozilla.org/~jorendorff/es6-draft.html#sec-method-definitions

BUG=v8:3516
LOG=Y
R=dslomov@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24048

[arv (Not doing code reviews), 2014-09-17 16:20:01]

cleanup

[arv (Not doing code reviews), 2014-09-17 16:22:05]

arv@chromium.org changed reviewers:
+ dslomov@chromium.org, wingo@igalia.com

[Dmitry Lomov (no reviews), 2014-09-18 07:43:57]

Cool stuff! lgtm from my side, with some nits.

https://codereview.chromium.org/577973002/diff/20001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/577973002/diff/20001/src/globals.h#newcode776
src/globals.h:776: (FunctionKind::kGeneratorFunction |
FunctionKind::kConciseMethod);
The comment in this function is now obsolete.

https://codereview.chromium.org/577973002/diff/20001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/577973002/diff/20001/src/preparser.h#newcode1979
src/preparser.h:1979: if (is_generator) {
Nit: maybe the following is better:
1) add ``kConciseGeneratorMethod = kConciseMethod | kGeneratorFuction`` to
FunctionKind (to avoid static_casts)
2) Here, write:
 FunctionKind kind = is_generator ? kConciseGeneratorMethod : kConciseMethod;

[wingo, 2014-09-18 07:50:52]

Hah, I had the same comment as Dmitry.  One question: where do you test the new
error case (non-static generator constructors)?

[arv (Not doing code reviews), 2014-09-18 15:55:58]

Cleanup based on code review

[arv (Not doing code reviews), 2014-09-18 15:59:03]

https://codereview.chromium.org/577973002/diff/20001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/577973002/diff/20001/src/globals.h#newcode776
src/globals.h:776: (FunctionKind::kGeneratorFunction |
FunctionKind::kConciseMethod);
On 2014/09/18 at 07:43:57, Dmitry Lomov (chromium) wrote:
> The comment in this function is now obsolete.

Done.

https://codereview.chromium.org/577973002/diff/20001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/577973002/diff/20001/src/preparser.h#newcode1979
src/preparser.h:1979: if (is_generator) {
On 2014/09/18 at 07:43:57, Dmitry Lomov (chromium) wrote:
> Nit: maybe the following is better:
> 1) add ``kConciseGeneratorMethod = kConciseMethod | kGeneratorFuction`` to
FunctionKind (to avoid static_casts)
> 2) Here, write:
>  FunctionKind kind = is_generator ? kConciseGeneratorMethod : kConciseMethod;

Thanks. That is much better.

https://codereview.chromium.org/577973002/diff/40001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/577973002/diff/40001/test/cctest/test-parsing...
test/cctest/test-parsing.cc:3877: "*constructor() {}",
Andy, non static generator constructor is tested here.

[Dmitry Lomov (no reviews), 2014-09-18 16:51:59]

still lgtm :)

[arv (Not doing code reviews), 2014-09-18 17:14:19]

Committed patchset #3 (id:40001) manually as 24048 (presubmit successful).