Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 577833003: Revert of Clean up GestureEventDetails constructors and fix unit tests (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
sky, lanwei
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, dcheng, yukishiino+watch_chromium.org, ben+aura_chromium.org, Ilya Sherman, tdanderson+views_chromium.org, benquan, jdduke+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, tdresser+watch_chromium.org, penghuang+watch_chromium.org, oshima+watch_chromium.org, ben+corewm_chromium.org, ben+views_chromium.org, rouslan+autofillwatch_chromium.org, tfarina, stevenjb+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, James Su, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up GestureEventDetails constructors and fix unit tests (patchset #1 id:20001 of https://codereview.chromium.org/573963005/) Reason for revert: This broke TouchEditableImplAuraTest.TouchSelectionOnLongPressTest. [24874:24874:0916/151803:584385367:FATAL:gesture_event_details.cc(54)] Check failed: false. Invalid event type for constructor: 32 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=undefined&tests=TouchEditableImplAuraTest.TouchSelectionOnLongPressTest&testType=content_browsertests http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=undefined&tests=TouchEditableImplAuraTest.TouchSelectionOnLongPressTest&testType=content_browsertests Original issue's description: > Clean up GestureEventDetails constructors and fix unit tests. > > A new version of Issue 565583005: Clean up GestureEventDetails > constructors > https://codereview.chromium.org/565583005/ > > BUG=350942 > > TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org > > Committed: https://crrev.com/874611d5ab5b879648682c1ea41062bebc9c95e5 > Cr-Commit-Position: refs/heads/master@{#295144} TBR=sky@chromium.org,lanwei@chromium.org NOTREECHECKS=true NOTRY=true BUG=350942 Committed: https://crrev.com/f0003ece045e6e30ff3d70be4ea818c365b08cf6 Cr-Commit-Position: refs/heads/master@{#295223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -178 lines) Patch
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/home/home_card_gesture_manager_unittest.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views_unittest.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/gesture_text_selector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M ui/aura/remote_window_tree_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_event_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_event_data_packet_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 7 chunks +8 lines, -11 lines 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_event_details.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/events/gesture_event_details.cc View 3 chunks +18 lines, -8 lines 0 comments Download
M ui/events/test/event_generator.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_view_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 7 chunks +22 lines, -24 lines 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 5 chunks +25 lines, -15 lines 0 comments Download
M ui/views/view_targeter_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ui/views/widget/root_view_unittest.cc View 6 chunks +36 lines, -18 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 8 chunks +32 lines, -26 lines 0 comments Download
M ui/wm/core/user_activity_detector_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
horo
Created Revert of Clean up GestureEventDetails constructors and fix unit tests
6 years, 3 months ago (2014-09-17 03:47:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577833003/1
6 years, 3 months ago (2014-09-17 03:48:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6dfd07e2dedfa3dcbe5d2098bfd4e96398f80045
6 years, 3 months ago (2014-09-17 03:49:29 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 03:49:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0003ece045e6e30ff3d70be4ea818c365b08cf6
Cr-Commit-Position: refs/heads/master@{#295223}

Powered by Google App Engine
This is Rietveld 408576698