ui/events/gesture_event_details.h - Issue 577833003: Revert of Clean up GestureEventDetails constructors and fix unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_event_details.h

Issue 577833003: Revert of Clean up GestureEventDetails constructors and fix unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc ('k') | ui/events/gesture_event_details.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/gesture_event_details.h

diff --git a/ui/events/gesture_event_details.h b/ui/events/gesture_event_details.h

index da7a60bef2a87217c6c4e0082f3230ee46c2be84..58d28fa7f946ce4c73a3af3ba33f8179b21217ad 100644

--- a/ui/events/gesture_event_details.h

+++ b/ui/events/gesture_event_details.h

@@ -16,7 +16,6 @@

struct EVENTS_BASE_EXPORT GestureEventDetails {

public:

GestureEventDetails();

- explicit GestureEventDetails(EventType type);

GestureEventDetails(EventType type, float delta_x, float delta_y);

EventType type() const { return type_; }

@@ -124,12 +123,6 @@

data.tap_count = tap_count;

}

- void set_scale(float scale) {

- DCHECK_GE(scale, 0.0f);

- DCHECK_EQ(type_, ET_GESTURE_PINCH_UPDATE);

- data.scale = scale;

- }

private:

EventType type_;

union Details {

« no previous file with comments | « ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc ('k') | ui/events/gesture_event_details.cc » ('j') | no next file with comments »