Issue 577723002: gn: gyp_flag_compare.py, don't return non-zero exit code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 577723002: gn: gyp_flag_compare.py, don't return non-zero exit code (Closed)

Created:
6 years, 3 months ago by scottmg

Modified:
6 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

gn: gyp_flag_compare.py, don't return non-zero exit code Going to add it as a build step: https://codereview.chromium.org/575733003/ but for now, don't want to error out. TBR=brettw@chromium.org BUG=335824 Committed: https://crrev.com/715038ab4cac42587899267bf07f24975bcf94dc Cr-Commit-Position: refs/heads/master@{#295131}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/gn/bin/gyp_flag_compare.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577723002/1

6 years, 3 months ago (2014-09-16 19:26:30 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as db36c9dcfd9e74d04381be2a463d7449ede82329

6 years, 3 months ago (2014-09-16 19:50:47 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-16 19:51:18 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/715038ab4cac42587899267bf07f24975bcf94dc
Cr-Commit-Position: refs/heads/master@{#295131}