tools/gn/bin/gyp_flag_compare.py - Issue 577723002: gn: gyp_flag_compare.py, don't return non-zero exit code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/bin/gyp_flag_compare.py

Issue 577723002: gn: gyp_flag_compare.py, don't return non-zero exit code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/bin/gyp_flag_compare.py

diff --git a/tools/gn/bin/gyp_flag_compare.py b/tools/gn/bin/gyp_flag_compare.py

index 8439ca3ef74196674956e20679f1f34ba33f9935..80b37dc6b413c51c61714c6257f671893a6863f0 100755

--- a/tools/gn/bin/gyp_flag_compare.py

+++ b/tools/gn/bin/gyp_flag_compare.py

@@ -214,7 +214,8 @@ def main():

print diff

print 'Total differences:', g_total_differences

- return 1 if files_with_given_differences or different_source_list else 0

+ # TODO(scottmg): Return failure on difference once we're closer to identical.

+ return 0

if __name__ == '__main__':

« no previous file with comments | « no previous file | no next file » | no next file with comments »