Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 577543002: Revert of Revert CL 117933003. Re-add resource speculative prefetching code. (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
CC:
chromium-reviews, shishir+watch_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Revert CL 117933003. Re-add resource speculative prefetching code. (patchset #10 id:180001 of https://codereview.chromium.org/462423004/) Reason for revert: This caused a bunch of memory leaks in following tests: - ResourcePrefetcherTest.TestPrefetcherFinishes - ResourcePrefetcherTest.TestPrefetcherStopped Linux Chromium OS ASan LSan Tests (3) http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/3216 Linux ASan LSan Tests (2) http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7460 Original issue's description: > Revert CL 117933003. Re-add speculative resource prefetching code. > https://codereview.chromium.org/117933003/ > > The speculative resource prefetching code was experimental code developed by > shishir@. He found that it has little improvement on desktop Chrome (win). We > though this should be beneficial to mobile browsers. After discussing with > tburkard@ and kenjibaheux@, we decided to bring the code back and do more > analysis on mobile devices. Reverting the patchset to re-add the code is the > first step. > > The following design doc has discussed all related approaches and action items. > https://docs.google.com/a/google.com/document/d/1ie3hu-zNNXvmTXm3aJAtKUGOh6nZfbNjA0aZE1bzzIg/edit?usp=sharing > > BUG=408399, 405690 > > Committed: https://crrev.com/825722d5939dc0832d124b70958501611e6a4628 > Cr-Commit-Position: refs/heads/master@{#294899} TBR=shishir@chromium.org,tburkard@chromium.org,kenjibaheux@chromium.org,jam@chromium.org,thestig@chromium.org,zhenw@chromium.org NOTREECHECKS=true NOTRY=true BUG=408399, 405690 Committed: https://crrev.com/f03864238c8a90971f6b0c4d0f5acb894c0dfcd2 Cr-Commit-Position: refs/heads/master@{#295011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5737 lines) Patch
D chrome/browser/net/resource_prefetch_predictor_observer.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/net/resource_prefetch_predictor_observer.cc View 1 chunk +0 lines, -202 lines 0 comments Download
M chrome/browser/predictors/predictor_database.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/predictors/predictor_database.cc View 8 chunks +1 line, -18 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_common.h View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_common.cc View 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor.h View 1 chunk +0 lines, -314 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor.cc View 1 chunk +0 lines, -1222 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor_factory.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor_factory.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor_tab_helper.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor_tables.h View 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor_tables.cc View 1 chunk +0 lines, -513 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc View 1 chunk +0 lines, -472 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 chunk +0 lines, -925 lines 0 comments Download
D chrome/browser/predictors/resource_prefetcher.h View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/predictors/resource_prefetcher.cc View 1 chunk +0 lines, -240 lines 0 comments Download
D chrome/browser/predictors/resource_prefetcher_manager.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/predictors/resource_prefetcher_manager.cc View 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/browser/predictors/resource_prefetcher_unittest.cc View 1 chunk +0 lines, -343 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 4 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 4 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/resources/predictors/predictors.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/predictors/predictors.js View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/predictors/resource_prefetch_predictor.html View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/resources/predictors/resource_prefetch_predictor.js View 1 chunk +0 lines, -102 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/predictors/predictors_handler.h View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/predictors/predictors_handler.cc View 3 chunks +0 lines, -77 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nhiroki
Created Revert of Revert CL 117933003. Re-add resource speculative prefetching code.
6 years, 3 months ago (2014-09-16 04:56:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577543002/1
6 years, 3 months ago (2014-09-16 04:56:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as f6e502a0318533725f18d50d6e822beb9e8986ba
6 years, 3 months ago (2014-09-16 04:58:01 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f03864238c8a90971f6b0c4d0f5acb894c0dfcd2 Cr-Commit-Position: refs/heads/master@{#295011}
6 years, 3 months ago (2014-09-16 04:59:23 UTC) #4
nhiroki
6 years, 3 months ago (2014-09-16 05:00:37 UTC) #5
Message was sent while issue was closed.
This emitted a lot of memory leak errors and I'm not sure if this happened only
in tests, so let me revert...

Powered by Google App Engine
This is Rietveld 408576698