Simplify VideoReader and VideoWriter

remoting/protocol/connection_to_client.cc

Index: remoting/protocol/connection_to_client.cc
diff --git a/remoting/protocol/connection_to_client.cc b/remoting/protocol/connection_to_client.cc
index a6d31434ab57589cd01a5d9c44b7fc08d48711c2..9ffd38f6fe2e6a71318ccd55e907acbcd4a029a1 100644
--- a/remoting/protocol/connection_to_client.cc
+++ b/remoting/protocol/connection_to_client.cc
@@ -134,9 +134,11 @@ void ConnectionToClient::OnSessionStateChange(Session::State state) {
       event_dispatcher_->set_sequence_number_callback(base::Bind(
           &ConnectionToClient::UpdateSequenceNumber, base::Unretained(this)));
 
-      video_writer_ = VideoWriter::Create(session_->config());
-      video_writer_->Init(session_.get(), base::Bind(
-          &ConnectionToClient::OnChannelInitialized, base::Unretained(this)));
+      video_writer_.reset(new VideoWriter());
+      video_writer_->Init(session_.get(),

[Wez, 2014/09/16 23:10:06]

nit: Does Init() need to be separate from construction, or could we combine the
two?

[Sergey Ulanov, 2014/09/17 21:52:06]

Yes. It's implemented in the ChannelDispatcherBase. These parameters could be
passed to the constructor, but then they would have to be duplicated for each
class based on ChannelDispatcherBase

[Wez, 2014/09/18 00:23:54]

Acknowledged.

+                          session_->config().video_config(),
+                          base::Bind(&ConnectionToClient::OnChannelInitialized,
+                                     base::Unretained(this)));
 
       audio_writer_ = AudioWriter::Create(session_->config());
       if (audio_writer_.get()) {