Simplify VideoReader and VideoWriter

remoting/protocol/connection_to_client.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/connection_to_client.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "net/base/io_buffer.h"
@@ skipping 116 matching lines @@
 
       event_dispatcher_.reset(new HostEventDispatcher());
       event_dispatcher_->Init(
           session_.get(), session_->config().event_config(),
           base::Bind(&ConnectionToClient::OnChannelInitialized,
                      base::Unretained(this)));
       event_dispatcher_->set_input_stub(input_stub_);
       event_dispatcher_->set_sequence_number_callback(base::Bind(
           &ConnectionToClient::UpdateSequenceNumber, base::Unretained(this)));
 
-      video_writer_ = VideoWriter::Create(session_->config());
-      video_writer_->Init(session_.get(), base::Bind(
-          &ConnectionToClient::OnChannelInitialized, base::Unretained(this)));
+      video_writer_.reset(new VideoWriter());
+      video_writer_->Init(session_.get(),

[Wez, 2014/09/16 23:10:06]

nit: Does Init() need to be separate from construction, or could we combine the
two?

[Sergey Ulanov, 2014/09/17 21:52:06]

Yes. It's implemented in the ChannelDispatcherBase. These parameters could be
passed to the constructor, but then they would have to be duplicated for each
class based on ChannelDispatcherBase

[Wez, 2014/09/18 00:23:54]

Acknowledged.

+                          session_->config().video_config(),
+                          base::Bind(&ConnectionToClient::OnChannelInitialized,
+                                     base::Unretained(this)));
 
       audio_writer_ = AudioWriter::Create(session_->config());
       if (audio_writer_.get()) {
         audio_writer_->Init(
             session_.get(), session_->config().audio_config(),
             base::Bind(&ConnectionToClient::OnChannelInitialized,
                        base::Unretained(this)));
       }
 
       // Notify the handler after initializing the channels, so that
@@ skipping 52 matching lines @@
 
 void ConnectionToClient::CloseChannels() {
   control_dispatcher_.reset();
   event_dispatcher_.reset();
   video_writer_.reset();
   audio_writer_.reset();
 }
 
 }  // namespace protocol
 }  // namespace remoting