Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 577353006: Update KeystoneRegistration.framework to 1.2.0.7671 (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
oemilyo
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update KeystoneRegistration.framework to 1.2.0.7671. The big change in this version is that an installation attempt initiated by the application can show up as ondemand on the server. This will allow us to provide throttled Mac downloads (such as a "5% push") with correct behavior. A previous registration framework, 1.2.0.6782, intended to fix this bug was backed out (via DEPS) because it was not compatible with older installed Keystones. This version contains a fix for that problem. Another previous registration framework, 1.2.0.7407, was backed out because it contained bugs in its installer. Previous commit: r245361, https://codereview.chromium.org/141193002 Backed out: r245603, https://codereview.chromium.org/141583005 Tried again: r261532, https://codereview.chromium.org/212703006 Backed out: r262037, https://codereview.chromium.org/227173002 BUG=35495 R=oemilyo@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/186f0c58365c502d28755a797333b3841eef191e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M chrome/browser/mac/keystone_glue.mm View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/mac/keystone_glue_unittest.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/mac/keystone_registration.h View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-22 21:31:47 UTC) #2
oemilyo
https://codereview.chromium.org/577353006/diff/1/chrome/browser/mac/keystone_registration.h File chrome/browser/mac/keystone_registration.h (right): https://codereview.chromium.org/577353006/diff/1/chrome/browser/mac/keystone_registration.h#newcode64 chrome/browser/mac/keystone_registration.h:64: - (BOOL)setActive; setActive is still (void) in 7671. (The ...
6 years, 3 months ago (2014-09-22 21:45:23 UTC) #3
oemilyo
lgtm https://codereview.chromium.org/577353006/diff/1/chrome/browser/mac/keystone_registration.h File chrome/browser/mac/keystone_registration.h (right): https://codereview.chromium.org/577353006/diff/1/chrome/browser/mac/keystone_registration.h#newcode64 chrome/browser/mac/keystone_registration.h:64: - (BOOL)setActive; Ignore my comment... this actually got ...
6 years, 3 months ago (2014-09-22 21:48:37 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/186f0c58365c502d28755a797333b3841eef191e Cr-Commit-Position: refs/heads/master@{#296130}
6 years, 3 months ago (2014-09-23 02:28:52 UTC) #5
Mark Mentovai
6 years, 3 months ago (2014-09-23 02:28:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 186f0c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698