Issue 141583005: Back out trunk r245361.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141583005: Back out trunk r245361. (Closed)

Created:
6 years, 11 months ago by Mark Mentovai

Modified:
6 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Back out trunk r245361. Go back to KeystoneRegistration.framework 1.1.0.3659. The new registration framework 1.2.0.6782, when using -[KSRegistration checkForUpdateWasUserInitiated:YES], is not compatible with an older installed Keystone version such as the current 1.1.0.3973. This results in the About page showing "Update failed (error: 11)" and this message being printed to stderr: ksadmin: unrecognized option `--user-initiated' In this case, updating is not broken, and Keystone will continue to update Chrome in the background, but no indication of update availability will be made in Chrome’s about page. > Update KeystoneRegistration.framework to 1.2.0.6782. > > The big change in this version is that an installation attempt initiated by > the application can show up as ondemand on the server. This will allow us to > provide throttled Mac downloads (such as a "5% push") with correct behavior. > > BUG=35495 > R=thakis@chromium.org > > Review URL: https://codereview.chromium.org/141193002 BUG=35495 TBR=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245603

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -8 lines)			Patch
M	trunk/src/chrome/browser/mac/keystone_glue.mm	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/mac/keystone_glue_unittest.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/mac/keystone_registration.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r245603.

Expand Messages | Collapse Messages