Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 577313002: Mojo: Give ChannelEndpoint the remote ID and ProxyMessagePipeEndpoint the ChannelEndpoint. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Give ChannelEndpoint the remote ID and ProxyMessagePipeEndpoint the ChannelEndpoint. Witht this, I can begin removing knowledge of the Channel, etc. from the ProxyMessagePipeEndpoint. (Eventually, ProxyMessagePipeEndpoint will really just look like a stupid proxy, and relative sanity will prevail.) R=darin@chromium.org Committed: https://crrev.com/b1559135b834fdeac19dd25295d8e316637b3643 Cr-Commit-Position: refs/heads/master@{#295497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -27 lines) Patch
M mojo/system/channel.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M mojo/system/channel_endpoint.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/system/channel_endpoint.cc View 1 chunk +31 lines, -7 lines 0 comments Download
M mojo/system/message_pipe.h View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/system/message_pipe.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/system/message_pipe_endpoint.h View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/system/message_pipe_endpoint.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 3 chunks +7 lines, -1 line 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.cc View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 3 months ago (2014-09-18 17:16:14 UTC) #1
darin (slow to review)
lgtm
6 years, 3 months ago (2014-09-18 17:23:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/577313002/1
6 years, 3 months ago (2014-09-18 17:33:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 384d081816fe30746e81dc2253d207a6044024b9
6 years, 3 months ago (2014-09-18 18:17:10 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:17:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1559135b834fdeac19dd25295d8e316637b3643
Cr-Commit-Position: refs/heads/master@{#295497}

Powered by Google App Engine
This is Rietveld 408576698