Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 577293002: Use task_t, thread_t, and exception_handler_t uniformly (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Use more-specific typedefs for send rights to task, thread, and exception handler ports. task_t, thread_t, and exception_handler_t are typedefs for mach_port_t. They are more descriptive than mach_port_t, and are already in use in exc_server_variants. TEST=util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4d35ffa80ebafdcdec5b580323a1005b182d2ec9

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M tools/exception_port_tool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M util/mac/process_reader.h View 3 chunks +3 lines, -3 lines 0 comments Download
M util/mac/process_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M util/mac/process_reader_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M util/mach/exc_server_variants_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/mach/mach_extensions.h View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/mach_extensions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/mach/mach_message_server.cc View 3 chunks +2 lines, -4 lines 1 comment Download
M util/mach/task_memory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M util/mach/task_memory.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/test/mac/mach_multiprocess.h View 1 chunk +1 line, -1 line 0 comments Download
M util/test/mac/mach_multiprocess.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
https://codereview.chromium.org/577293002/diff/1/util/mach/mach_message_server.cc File util/mach/mach_message_server.cc (left): https://codereview.chromium.org/577293002/diff/1/util/mach/mach_message_server.cc#oldcode136 util/mach/mach_message_server.cc:136: mach_port_t self = mach_task_self(); This was the only place ...
6 years, 3 months ago (2014-09-18 16:16:13 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-18 16:44:31 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-18 17:53:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 4d35ffa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698