Use task_t, thread_t, and exception_handler_t uniformly

util/mach/mach_message_server.cc

Index: util/mach/mach_message_server.cc
diff --git a/util/mach/mach_message_server.cc b/util/mach/mach_message_server.cc
index 98e41041750b0310ab1f01da7e75eec1e45f30f6..e79acfe4dcfdd2a472edab863050f522ce992339 100644
--- a/util/mach/mach_message_server.cc
+++ b/util/mach/mach_message_server.cc
@@ -133,8 +133,6 @@ mach_msg_return_t MachMessageServer::Run(Interface* interface,
       (options & MACH_SEND_TRAILER) ? (max_reply_size + MAX_TRAILER_SIZE)
                                     : max_reply_size);
 
-  mach_port_t self = mach_task_self();

[Mark Mentovai, 2014/09/18 16:16:13]

This was the only place in bpoop where mach_task_self() was cached in a local
variable.

Since we know how mach_task_self() actually works, it’s pointless to cache it in
a local. In all modern code, I just use it inline wherever I need it.

-
   kern_return_t kr;
 
   do {
@@ -146,7 +144,7 @@ mach_msg_return_t MachMessageServer::Run(Interface* interface,
 
     while (!request_scoper.address()) {
       vm_address_t request_addr;
-      kr = vm_allocate(self,
+      kr = vm_allocate(mach_task_self(),
                        &request_addr,
                        this_request_alloc,
                        VM_FLAGS_ANYWHERE | VM_MAKE_TAG(VM_MEMORY_MACH_MSG));
@@ -189,7 +187,7 @@ mach_msg_return_t MachMessageServer::Run(Interface* interface,
     }
 
     vm_address_t reply_addr;
-    kr = vm_allocate(self,
+    kr = vm_allocate(mach_task_self(),
                      &reply_addr,
                      reply_alloc,
                      VM_FLAGS_ANYWHERE | VM_MAKE_TAG(VM_MEMORY_MACH_MSG));