Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: content/browser/service_worker/service_worker_cache_unittest.cc

Issue 576973004: Make ServiceWorkerFetchRequest and ServiceWorkerResponse header maps case insensitive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses comment from PS4 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_cache_unittest.cc
diff --git a/content/browser/service_worker/service_worker_cache_unittest.cc b/content/browser/service_worker/service_worker_cache_unittest.cc
index acf51a190eaf9a52b9aaf017d248237f89af7077..715565b802d9fb1741a5f69bdac56c7ed63df09c 100644
--- a/content/browser/service_worker/service_worker_cache_unittest.cc
+++ b/content/browser/service_worker/service_worker_cache_unittest.cc
@@ -89,7 +89,7 @@ class ServiceWorkerCacheTest : public testing::Test {
}
void CreateRequests(ChromeBlobStorageContext* blob_storage_context) {
- std::map<std::string, std::string> headers;
+ ServiceWorkerHeaderMap headers;
headers.insert(std::make_pair("a", "a"));
headers.insert(std::make_pair("b", "b"));
body_request_ = ServiceWorkerFetchRequest(
@@ -398,6 +398,29 @@ TEST_P(ServiceWorkerCacheTestP, QuickStressBody) {
}
#endif // OS_WIN
+TEST_F(ServiceWorkerCacheTest, CaselessServiceWorkerResponseHeaders) {
+ // ServiceWorkerCache depends on ServiceWorkerResponse having caseless
+ // headers so that it can quickly lookup vary headers.
+ ServiceWorkerResponse response(
+ GURL("http://www.example.com"), 200, "OK", ServiceWorkerHeaderMap(), "");
+ response.headers["content-type"] = "foo";
+ response.headers["Content-Type"] = "bar";
+ EXPECT_EQ("bar", response.headers["content-type"]);
+}
+
+TEST_F(ServiceWorkerCacheTest, CaselessServiceWorkerFetchRequestHeaders) {
+ // ServiceWorkerCache depends on ServiceWorkerFetchRequest having caseless
+ // headers so that it can quickly lookup vary headers.
+ ServiceWorkerFetchRequest request(GURL("http://www.example.com"),
+ "GET",
+ ServiceWorkerHeaderMap(),
+ GURL(""),
+ false);
+ request.headers["content-type"] = "foo";
+ request.headers["Content-Type"] = "bar";
+ EXPECT_EQ("bar", request.headers["content-type"]);
+}
+
INSTANTIATE_TEST_CASE_P(ServiceWorkerCacheTest,
ServiceWorkerCacheTestP,
::testing::Values(false, true));

Powered by Google App Engine
This is Rietveld 408576698