Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 57683002: Web Animations CSS: Add use counter analytics to CSSAnimations. (Closed)

Created:
7 years, 1 month ago by rjwright
Modified:
7 years, 1 month ago
Reviewers:
dstockwell, shans, rjwright1
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@MoveKeyframeStyleResovler
Visibility:
Public.

Description

Add use counter analytics to CSSAnimations. Count each specified CSS Transition every time it runs. Count each requested CSS Animation, including those on non-animatable properties. BUG=317604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161800

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Add UseCounter for CSS trasitions in Web Animations. #

Patch Set 4 : Include non-animatable properties in use counter for CSSAnimations. #

Total comments: 2

Patch Set 5 : Rebased onto new local changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Source/core/animation/css/CSSAnimations.cpp View 1 2 3 4 5 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rjwright1
Not for landing, I need to land codereview.chromium.org/57593002 first. I'm not sure if I've put ...
7 years, 1 month ago (2013-11-04 08:21:43 UTC) #1
rjwright
I made the changes you asked for, Doug. Checked chrome://histograms after animating left (animatable) and ...
7 years, 1 month ago (2013-11-05 06:36:04 UTC) #2
dstockwell
lgtm Need to link to a bug, and add the 'Web Animations CSS: ' prefix ...
7 years, 1 month ago (2013-11-05 22:54:18 UTC) #3
Timothy Loh
You probably shouldn't remove everyone from the cc list...
7 years, 1 month ago (2013-11-10 23:46:39 UTC) #4
dstockwell
On 2013/11/10 23:46:39, Timothy Loh wrote: > You probably shouldn't remove everyone from the cc ...
7 years, 1 month ago (2013-11-10 23:49:20 UTC) #5
rjwright1
https://codereview.chromium.org/57683002/diff/80001/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/57683002/diff/80001/Source/core/animation/css/CSSAnimations.cpp#newcode347 Source/core/animation/css/CSSAnimations.cpp:347: // Update use counter. On 2013/11/05 22:54:18, dstockwell wrote: ...
7 years, 1 month ago (2013-11-11 12:18:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjwright@chromium.org/57683002/140001
7 years, 1 month ago (2013-11-11 12:20:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjwright@chromium.org/57683002/140001
7 years, 1 month ago (2013-11-12 11:38:27 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 12:14:53 UTC) #9
Message was sent while issue was closed.
Change committed as 161800

Powered by Google App Engine
This is Rietveld 408576698