Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: Source/core/rendering/RenderTable.h

Issue 576823004: Move painting code for tables into *Paint classes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderTable.h
diff --git a/Source/core/rendering/RenderTable.h b/Source/core/rendering/RenderTable.h
index 650c1587797e7e4a40d1c7ee36fc487bd67beffd..fbcb9d726a6a5b9ea0eed5fb95b2847137af729c 100644
--- a/Source/core/rendering/RenderTable.h
+++ b/Source/core/rendering/RenderTable.h
@@ -245,6 +245,7 @@ public:
m_collapsedBorders.clear();
}
const CollapsedBorderValue* currentBorderValue() const { return m_currentBorder; }
+ void setCurrentBorderValue(const CollapsedBorderValue* val) { m_currentBorder = val; }
mstensho (USE GERRIT) 2014/09/19 10:50:11 m_currentBorder is for painting. So am I right in
chrishtr 2014/09/19 16:35:24 Done.
bool hasSections() const { return m_head || m_foot || m_firstBody; }
@@ -268,6 +269,14 @@ public:
void addColumn(const RenderTableCol*);
void removeColumn(const RenderTableCol*);
+ // FIXME: get rid of this method and move to paint/
+ virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&) OVERRIDE;
mstensho (USE GERRIT) 2014/09/19 10:50:11 If the above comment only refers to this method, I
chrishtr 2014/09/19 16:35:24 Done.
+ virtual void paintMask(PaintInfo&, const LayoutPoint&) OVERRIDE;
+
+ const CollapsedBorderValues& collapsedBorders() { return m_collapsedBorders; }
+ void subtractCaptionRect(LayoutRect&) const;
+ void recalcCollapsedBorders();
+
protected:
virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) OVERRIDE;
virtual void simplifiedNormalFlowLayout() OVERRIDE;
@@ -279,8 +288,6 @@ private:
virtual void paint(PaintInfo&, const LayoutPoint&) OVERRIDE;
virtual void paintObject(PaintInfo&, const LayoutPoint&) OVERRIDE;
- virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&) OVERRIDE;
- virtual void paintMask(PaintInfo&, const LayoutPoint&) OVERRIDE;
virtual void layout() OVERRIDE;
virtual void computeIntrinsicLogicalWidths(LayoutUnit& minWidth, LayoutUnit& maxWidth) const OVERRIDE;
virtual void computePreferredLogicalWidths() OVERRIDE;
@@ -304,9 +311,6 @@ private:
virtual void addOverflowFromChildren() OVERRIDE;
- void subtractCaptionRect(LayoutRect&) const;
-
- void recalcCollapsedBorders();
void recalcSections() const;
void layoutCaption(RenderTableCaption*);

Powered by Google App Engine
This is Rietveld 408576698