Move painting code for tables into *Paint classes.

Source/core/rendering/RenderTable.h

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 227 matching lines @@
     RenderTableCell* cellBefore(const RenderTableCell*) const;
     RenderTableCell* cellAfter(const RenderTableCell*) const;
 
     typedef Vector<CollapsedBorderValue> CollapsedBorderValues;
     void invalidateCollapsedBorders()
     {
         m_collapsedBordersValid = false;
         m_collapsedBorders.clear();
     }
     const CollapsedBorderValue* currentBorderValue() const { return m_currentBorder; }
+    void setCurrentBorderValue(const CollapsedBorderValue* val) { m_currentBorder = val; }

[mstensho (USE GERRIT), 2014/09/19 10:50:11]

m_currentBorder is for painting. So am I right in thinking that it doesn't
really belong in a renderer class? I'm wondering if you should add a FIXME for
this.

[chrishtr, 2014/09/19 16:35:24]

Done.

 
     bool hasSections() const { return m_head || m_foot || m_firstBody; }
 
     void recalcSectionsIfNeeded() const
     {
         if (m_needsSectionRecalc)
             recalcSections();
     }
 
     static RenderTable* createAnonymousWithParentRenderer(const RenderObject*);
     virtual RenderBox* createAnonymousBoxWithSameTypeAs(const RenderObject* parent) const OVERRIDE
     {
         return createAnonymousWithParentRenderer(parent);
     }
 
     const BorderValue& tableStartBorderAdjoiningCell(const RenderTableCell*) const;
     const BorderValue& tableEndBorderAdjoiningCell(const RenderTableCell*) const;
 
     void addCaption(const RenderTableCaption*);
     void removeCaption(const RenderTableCaption*);
     void addColumn(const RenderTableCol*);
     void removeColumn(const RenderTableCol*);
 
+    // FIXME: get rid of this method and move to paint/
+    virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&) OVERRIDE;

[mstensho (USE GERRIT), 2014/09/19 10:50:11]

If the above comment only refers to this method, I think there should be a blank
line after this declaration.

[chrishtr, 2014/09/19 16:35:24]

Done.

+    virtual void paintMask(PaintInfo&, const LayoutPoint&) OVERRIDE;
+
+    const CollapsedBorderValues& collapsedBorders() { return m_collapsedBorders; }
+    void subtractCaptionRect(LayoutRect&) const;
+    void recalcCollapsedBorders();
+
 protected:
     virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) OVERRIDE;
     virtual void simplifiedNormalFlowLayout() OVERRIDE;
 
 private:
     virtual const char* renderName() const OVERRIDE { return "RenderTable"; }
 
     virtual bool isTable() const OVERRIDE { return true; }
 
     virtual void paint(PaintInfo&, const LayoutPoint&) OVERRIDE;
     virtual void paintObject(PaintInfo&, const LayoutPoint&) OVERRIDE;
-    virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&) OVERRIDE;
-    virtual void paintMask(PaintInfo&, const LayoutPoint&) OVERRIDE;
     virtual void layout() OVERRIDE;
     virtual void computeIntrinsicLogicalWidths(LayoutUnit& minWidth, LayoutUnit& maxWidth) const OVERRIDE;
     virtual void computePreferredLogicalWidths() OVERRIDE;
     virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) OVERRIDE;
 
     virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const OVERRIDE;
     virtual int firstLineBoxBaseline() const OVERRIDE;
     virtual int inlineBlockBaseline(LineDirectionMode) const OVERRIDE;
 
     RenderTableCol* slowColElement(unsigned col, bool* startEdge, bool* endEdge) const;
 
     void updateColumnCache() const;
     void invalidateCachedColumns();
 
     virtual void updateLogicalWidth() OVERRIDE;
 
     LayoutUnit convertStyleLogicalWidthToComputedWidth(const Length& styleLogicalWidth, LayoutUnit availableWidth);
     LayoutUnit convertStyleLogicalHeightToComputedHeight(const Length& styleLogicalHeight);
 
     virtual LayoutRect overflowClipRect(const LayoutPoint& location, OverlayScrollbarSizeRelevancy = IgnoreOverlayScrollbarSize) OVERRIDE;
 
     virtual void addOverflowFromChildren() OVERRIDE;
 
-    void subtractCaptionRect(LayoutRect&) const;
-
-    void recalcCollapsedBorders();
     void recalcSections() const;
     void layoutCaption(RenderTableCaption*);
 
     void distributeExtraLogicalHeight(int extraLogicalHeight);
 
     mutable Vector<int> m_columnPos;
     mutable Vector<ColumnStruct> m_columns;
     mutable Vector<RenderTableCaption*> m_captions;
     mutable Vector<RenderTableCol*> m_columnRenderers;
 
@@ skipping 36 matching lines @@
     if (m_firstBody)
         return m_firstBody;
     return m_foot;
 }
 
 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderTable, isTable());
 
 } // namespace blink
 
 #endif // RenderTable_h