Make gn generate on Win

Make gn generate on Win

BUG=
R=brettw

Committed: https://crrev.com/39017e1de19051c3a3519c28ca980021ae098ee4
Cr-Commit-Position: refs/heads/master@{#295283}

[brettw, 2014-09-16 16:47:19]

lgtm

[ckocagil, 2014-09-16 17:05:14]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-09-16 17:06:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/576743002/1

[commit-bot: I haz the power, 2014-09-16 17:16:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 17:16:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ckocagil, 2014-09-16 20:12:00]

ckocagil@chromium.org changed reviewers:
+ sky@chromium.org

[ckocagil, 2014-09-16 20:12:30]

+sky: ash/BUILD.gn and ui/base/BUILD.gn

[sky, 2014-09-16 22:04:42]

https://codereview.chromium.org/576743002/diff/1/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/576743002/diff/1/ui/base/BUILD.gn#newcode726
ui/base/BUILD.gn:726: if (build_ime) {
Why move this?

[brettw, 2014-09-16 22:12:51]

Actually, I just went through I made it run on Windows since I had to do a push.
I think this change in ui/base should be better:
https://codereview.chromium.org/552983004/diff/1/ui/base/BUILD.gn

What do you think?

[ckocagil, 2014-09-17 14:39:18]

Patchset #2 (id:20001) has been deleted

[ckocagil, 2014-09-17 14:57:05]

https://codereview.chromium.org/576743002/diff/1/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/576743002/diff/1/ui/base/BUILD.gn#newcode726
ui/base/BUILD.gn:726: if (build_ime) {
On 2014/09/16 22:04:42, sky wrote:
> Why move this?

I had moved this because a -= operation below required a path to be already
added to sources. Brett fixed the ui gn failures in
https://codereview.chromium.org/552983004, so I'm rebasing this CL and removing
you from the reviewer list.

[ckocagil, 2014-09-17 14:57:17]

ckocagil@chromium.org changed reviewers:
- sky@chromium.org

[ckocagil, 2014-09-17 15:03:13]

On 2014/09/16 22:12:51, brettw wrote:
> Actually, I just went through I made it run on Windows since I had to do a
push.
> I think this change in ui/base should be better:
> https://codereview.chromium.org/552983004/diff/1/ui/base/BUILD.gn
> 
> What do you think?

I commented on the issue (in case you asked me and not Scott).

I assume the remaining changes in this CL after rebase are still good. Checking
CQ box.

[ckocagil, 2014-09-17 15:04:43]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-09-17 15:05:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/576743002/40001

[commit-bot: I haz the power, 2014-09-17 16:04:00]

Committed patchset #2 (id:40001) as cf205e50b6265cafb5c9cd22917f133f038cb61a

[commit-bot: I haz the power, 2014-09-17 16:04:31]

Patchset 2 (id:??) landed as
https://crrev.com/39017e1de19051c3a3519c28ca980021ae098ee4
Cr-Commit-Position: refs/heads/master@{#295283}