Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552983004: Pull buildtools to get GN 295140 (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
Chris Masone
CC:
chromium-reviews, ozone-reviews_chromium.org, cbentzel+watch_chromium.org, sadrul, tfarina, kalyank, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Pull buildtools to get GN 295140 Fix GN build for ozone and official. TBR=cmasone@chromium.org Committed: https://crrev.com/0d9398539d5a78e8025eeb1c92f9d396c946e105 Cr-Commit-Position: refs/heads/master@{#295181}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -22 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ash/BUILD.gn View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/BUILD.gn View 2 chunks +4 lines, -12 lines 0 comments Download
M third_party/mach_override/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/base/BUILD.gn View 2 chunks +3 lines, -2 lines 2 comments Download
M ui/ozone/platform/dri/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
brettw
6 years, 3 months ago (2014-09-16 23:27:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552983004/1
6 years, 3 months ago (2014-09-16 23:30:09 UTC) #3
Chris Masone
lgtm
6 years, 3 months ago (2014-09-16 23:31:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6ef703b4ea2b5cc6ff920158c521d3eba9dd787d
6 years, 3 months ago (2014-09-17 00:00:07 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0d9398539d5a78e8025eeb1c92f9d396c946e105 Cr-Commit-Position: refs/heads/master@{#295181}
6 years, 3 months ago (2014-09-17 00:00:44 UTC) #6
ckocagil
https://codereview.chromium.org/552983004/diff/1/ui/base/BUILD.gn File ui/base/BUILD.gn (right): https://codereview.chromium.org/552983004/diff/1/ui/base/BUILD.gn#newcode762 ui/base/BUILD.gn:762: "ime/chromeos/character_composer_unittest.cc", Looks like these are being removed before they ...
6 years, 3 months ago (2014-09-17 15:03:27 UTC) #7
tfarina
6 years, 3 months ago (2014-09-17 15:56:00 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/552983004/diff/1/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/552983004/diff/1/ui/base/BUILD.gn#newcode762
ui/base/BUILD.gn:762: "ime/chromeos/character_composer_unittest.cc",
On 2014/09/17 15:03:27, ckocagil wrote:
> Looks like these are being removed before they are added. Perhaps these should
> be moved to a conditional += statement in the build_ime block below.
I will look into this.

Powered by Google App Engine
This is Rietveld 408576698