Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 576613002: Make it easier to parse the output assertion (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 2 months ago
Reviewers:
Nico
CC:
grit-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master
Visibility:
Public.

Description

Make it easier to parse the output assertion Currently, when the list of outputs doesn't match the expected outputs, grit just prints a big unreadable block of text. This change just makes it much easier to parse that output and fix the offending expectations.

Patch Set 1 #

Patch Set 2 : Break long line :/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M grit/tool/build.py View 1 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
cjhopman
thakis: *
6 years, 3 months ago (2014-09-16 01:26:23 UTC) #2
Nico
lgtm
6 years, 3 months ago (2014-09-16 04:03:47 UTC) #3
Nico
(let me know if you need me to land this)
6 years, 3 months ago (2014-09-16 04:04:00 UTC) #4
cjhopman
6 years, 2 months ago (2014-09-24 20:02:08 UTC) #5
On 2014/09/16 04:04:00, Nico (hiding) wrote:
> (let me know if you need me to land this)

Yeah, I'm not a grit committer so if you could land this that'd be great.

Powered by Google App Engine
This is Rietveld 408576698