Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 576553002: remove WEB_ANIMATION_SUPPORTS_FULL_DIRECTION guards (Closed)

Created:
6 years, 3 months ago by a.renevier
Modified:
6 years, 3 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove WEB_ANIMATION_SUPPORTS_FULL_DIRECTION guards This is the 3rd part accelerated direction control. The legacy code was handling alternatesdirection instead of the full set of direction controls. Now that blink side has landed, we can remove this legacy code. It builds on top of https://codereview.chromium.org/227733004 and https://codereview.chromium.org/225183014 BUG=348071 Committed: https://crrev.com/bb01a925a37bdebc8d46b1bd88d27447957f3bcb Cr-Commit-Position: refs/heads/master@{#294965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M cc/blink/web_animation_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/blink/web_animation_impl.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M cc/blink/web_animation_unittest.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
a.renevier
Will I need a 4th patch afterwards, to remove the line #define WEB_ANIMATION_SUPPORTS_FULL_DIRECTION 1 in ...
6 years, 3 months ago (2014-09-15 22:01:47 UTC) #2
a.renevier
6 years, 3 months ago (2014-09-15 22:01:57 UTC) #3
ajuma
lgtm On 2014/09/15 22:01:47, a.renevier wrote: > Will I need a 4th patch afterwards, to ...
6 years, 3 months ago (2014-09-15 23:05:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576553002/1
6 years, 3 months ago (2014-09-15 23:32:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 669d1577796e2c56046af15f31f51ff93d9df2d8
6 years, 3 months ago (2014-09-16 01:35:23 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 01:39:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb01a925a37bdebc8d46b1bd88d27447957f3bcb
Cr-Commit-Position: refs/heads/master@{#294965}

Powered by Google App Engine
This is Rietveld 408576698