Make proto enums canonical for ReadState/WriteState/ConnectState.

Make protobuf enums canonical for ReadState/WriteState/ConnectState.
Delete redundant non-proto ReadState/WriteState/ConnectState enums.
Add cast protogen rule to extension registration deps.

BUG=

Committed: https://crrev.com/f1624ddce4b88a5a950f65b511677b914c9caefb
Cr-Commit-Position: refs/heads/master@{#295602}

[Kevin M, 2014-09-15 20:46:17]

kmarshall@chromium.org changed reviewers:
+ rockot@chromium.org, wez@chromium.org

[Ken Rockot(use gerrit already), 2014-09-16 00:35:08]

gyp lgtm

[Kevin M, 2014-09-16 17:51:30]

kmarshall@chromium.org changed reviewers:
+ mfoltz@chromium.org

[Kevin M, 2014-09-16 17:52:03]

Adding Mark to R= list.

[mark a. foltz, 2014-09-16 18:09:21]

This will entangle the socket implementation and the logging, but I don't see us
removing the latter.

Please have imcheng@ review as he wrote the original logging implementation.

https://codereview.chromium.org/576483003/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/cast_socket.cc (right):

https://codereview.chromium.org/576483003/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_socket.cc:98: proto::ReadyState
ReadyStateToProto(ReadyState state) {
Move this (and ErrorStateToProto) to logger_util.cc

[Wez, 2014-09-16 18:22:42]

LGTM w/ the current crop of comments resolved.

https://codereview.chromium.org/576483003/diff/1/extensions/browser/api/api_r...
File extensions/browser/api/api_registration.gyp (right):

https://codereview.chromium.org/576483003/diff/1/extensions/browser/api/api_r...
extensions/browser/api/api_registration.gyp:24:
'<(DEPTH)/extensions/extensions.gyp:cast_channel_proto',
Does the GN file (see above) also need updating?

[Kevin M, 2014-09-16 19:49:59]

kmarshall@chromium.org changed reviewers:
+ imcheng@chromium.org

[Kevin M, 2014-09-16 19:50:33]

Also added imcheng to R=.

https://codereview.chromium.org/576483003/diff/1/extensions/browser/api/api_r...
File extensions/browser/api/api_registration.gyp (right):

https://codereview.chromium.org/576483003/diff/1/extensions/browser/api/api_r...
extensions/browser/api/api_registration.gyp:24:
'<(DEPTH)/extensions/extensions.gyp:cast_channel_proto',
On 2014/09/16 18:22:42, Wez wrote:
> Does the GN file (see above) also need updating?

Done.

https://codereview.chromium.org/576483003/diff/1/extensions/browser/api/cast_...
File extensions/browser/api/cast_channel/cast_socket.cc (right):

https://codereview.chromium.org/576483003/diff/1/extensions/browser/api/cast_...
extensions/browser/api/cast_channel/cast_socket.cc:98: proto::ReadyState
ReadyStateToProto(ReadyState state) {
On 2014/09/16 18:09:21, mark a. foltz wrote:
> Move this (and ErrorStateToProto) to logger_util.cc

Done.

[imcheng, 2014-09-16 23:47:55]

lgtm

Thanks!

[Kevin M, 2014-09-16 23:54:02]

The CQ bit was checked by kmarshall@chromium.org

[commit-bot: I haz the power, 2014-09-16 23:56:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/576483003/40001

[commit-bot: I haz the power, 2014-09-17 00:01:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-17 00:01:50]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/56832)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Kevin M, 2014-09-17 17:40:38]

Hi Ken (Rockot), I had to refactor the gyps somewhat to remove a circular gyp
dependency which was caught by the Mac trybots. Could you please take another
look? Thanks.

[Ken Rockot(use gerrit already), 2014-09-18 18:59:36]

On 2014/09/17 17:40:38, kmarshall wrote:
> Hi Ken (Rockot), I had to refactor the gyps somewhat to remove a circular gyp
> dependency which was caught by the Mac trybots. Could you please take another
> look? Thanks.

Oops, sorry for the delay. Could you please move the proto files into common? We
don't want any dependencies from common onto browser. Although this is not
a binary dependency and doesn't break anything, it's still conceptually weird.

[Kevin M, 2014-09-18 20:47:46]

On 2014/09/18 18:59:36, Ken Rockot wrote:
> On 2014/09/17 17:40:38, kmarshall wrote:
> > Hi Ken (Rockot), I had to refactor the gyps somewhat to remove a circular
gyp
> > dependency which was caught by the Mac trybots. Could you please take
another
> > look? Thanks.
> 
> Oops, sorry for the delay. Could you please move the proto files into common?
We
> don't want any dependencies from common onto browser. Although this is not
> a binary dependency and doesn't break anything, it's still conceptually weird.

OK, done. Please take a look.

[Ken Rockot(use gerrit already), 2014-09-18 20:51:36]

On 2014/09/18 20:47:46, kmarshall wrote:
> On 2014/09/18 18:59:36, Ken Rockot wrote:
> > On 2014/09/17 17:40:38, kmarshall wrote:
> > > Hi Ken (Rockot), I had to refactor the gyps somewhat to remove a circular
> gyp
> > > dependency which was caught by the Mac trybots. Could you please take
> another
> > > look? Thanks.
> > 
> > Oops, sorry for the delay. Could you please move the proto files into
common?
> We
> > don't want any dependencies from common onto browser. Although this is not
> > a binary dependency and doesn't break anything, it's still conceptually
weird.
> 
> OK, done. Please take a look.

Thanks. lgtm

[Kevin M, 2014-09-18 21:18:48]

The CQ bit was checked by kmarshall@chromium.org

[commit-bot: I haz the power, 2014-09-18 21:22:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/576483003/100001

[commit-bot: I haz the power, 2014-09-18 23:38:49]

Committed patchset #6 (id:100001) as 8d8d6868f5176f3c4ae735f5f864b8ca9521973d

[commit-bot: I haz the power, 2014-09-18 23:39:28]

Patchset 6 (id:??) landed as
https://crrev.com/f1624ddce4b88a5a950f65b511677b914c9caefb
Cr-Commit-Position: refs/heads/master@{#295602}

[Elliot Glaysher, 2014-09-19 00:01:49]

On 2014/09/18 23:39:28, I haz the power (commit-bot) wrote:
> Patchset 6 (id:??) landed as
> https://crrev.com/f1624ddce4b88a5a950f65b511677b914c9caefb
> Cr-Commit-Position: refs/heads/master@{#295602}

Manually reverted this patch in
https://chromium.googlesource.com/chromium/src/+/4b10ffbe3ef9bcc9a1007ae12b7e...

(Couldn't autorevert because of A+ in patch.)