Issue 57643005: [2D Canvas] Fix crash in createPattern method when using invalid canvas as source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 57643005: [2D Canvas] Fix crash in createPattern method when using invalid canvas as source. (Closed)

Created:
7 years, 1 month ago by Justin Novosad

Modified:
7 years, 1 month ago

Reviewers:
Stephen White

CC:
blink-reviews, jamesr, dsinclair, danakj, Rik, Stephen Chennney, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[2D Canvas] Fix crash in createPattern method when using invalid canvas as source. Before this fix, createPattern would crash when the source image is a canvas element with a backing store that failed to allocate. Correct behavior is to default to a transparent black pattern. The code to handle the default behavior was already there, but the constructor of Pattern was crashing when passed a null image. This patch fixes that crash. BUG=281504 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161286

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -5 lines)			Patch
A	LayoutTests/fast/canvas/canvas-large-pattern.html	View	1 chunk	+48 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/canvas/canvas-large-pattern-expected.txt	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	Source/core/platform/graphics/Pattern.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/57643005/1

7 years, 1 month ago (2013-11-04 20:10:40 UTC) #3

Message was sent while issue was closed.

Change committed as 161286

Expand Messages | Collapse Messages