Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 576173003: cc: Move UnoccludedContentRect to Occlusion. (Closed)

Created:
6 years, 3 months ago by vmpstr
Modified:
6 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Move UnoccludedContentRect to Occlusion. This patch moves OcclusionTracker::UnoccludedContentRect to Occlusion. This reduces OcclusionTracker API and makes it consistent with IsOccluded call. Follow-up work here will remove occlusion_tracker from these functions where possible and replace it with const Occlusion& occlusion. R=danakj BUG=410932 Committed: https://crrev.com/5b88d999fd4590b5ddf1c4223f58e496856c51f0 Cr-Commit-Position: refs/heads/master@{#295597}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -107 lines) Patch
M cc/layers/delegated_renderer_layer_impl.cc View 1 chunk +4 lines, -2 lines 2 comments Download
M cc/layers/io_surface_layer_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/layers/nine_patch_layer_impl.cc View 9 chunks +12 lines, -18 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M cc/layers/solid_color_layer_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/layers/surface_layer_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/layers/texture_layer_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/layers/tiled_layer_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M cc/layers/ui_resource_layer_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/layers/video_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/occlusion.h View 2 chunks +5 lines, -4 lines 0 comments Download
M cc/trees/occlusion.cc View 1 2 2 chunks +34 lines, -1 line 0 comments Download
M cc/trees/occlusion_tracker.h View 2 chunks +5 lines, -13 lines 0 comments Download
M cc/trees/occlusion_tracker.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M cc/trees/occlusion_tracker_perftest.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
vmpstr
PTAL https://codereview.chromium.org/576173003/diff/20001/cc/trees/occlusion_tracker_perftest.cc File cc/trees/occlusion_tracker_perftest.cc (right): https://codereview.chromium.org/576173003/diff/20001/cc/trees/occlusion_tracker_perftest.cc#newcode109 cc/trees/occlusion_tracker_perftest.cc:109: Occlusion occlusion = I'm not sure what's more ...
6 years, 3 months ago (2014-09-17 23:19:23 UTC) #1
vmpstr
https://codereview.chromium.org/576173003/diff/20001/cc/trees/occlusion_tracker_perftest.cc File cc/trees/occlusion_tracker_perftest.cc (right): https://codereview.chromium.org/576173003/diff/20001/cc/trees/occlusion_tracker_perftest.cc#newcode109 cc/trees/occlusion_tracker_perftest.cc:109: Occlusion occlusion = On 2014/09/17 23:19:23, vmpstr wrote: > ...
6 years, 3 months ago (2014-09-17 23:23:47 UTC) #2
danakj
LGTM https://codereview.chromium.org/576173003/diff/40001/cc/layers/delegated_renderer_layer_impl.cc File cc/layers/delegated_renderer_layer_impl.cc (right): https://codereview.chromium.org/576173003/diff/40001/cc/layers/delegated_renderer_layer_impl.cc#newcode448 cc/layers/delegated_renderer_layer_impl.cc:448: occlusion_tracker.GetCurrentOcclusionForLayer( Are you going to pass the Occlusion ...
6 years, 3 months ago (2014-09-18 01:48:45 UTC) #3
vmpstr
https://codereview.chromium.org/576173003/diff/40001/cc/layers/delegated_renderer_layer_impl.cc File cc/layers/delegated_renderer_layer_impl.cc (right): https://codereview.chromium.org/576173003/diff/40001/cc/layers/delegated_renderer_layer_impl.cc#newcode448 cc/layers/delegated_renderer_layer_impl.cc:448: occlusion_tracker.GetCurrentOcclusionForLayer( On 2014/09/18 01:48:45, danakj wrote: > Are you ...
6 years, 3 months ago (2014-09-18 21:45:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/576173003/40001
6 years, 3 months ago (2014-09-18 21:46:07 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 95f99b4b7424400522297c40b009fb0d70153ae0
6 years, 3 months ago (2014-09-18 23:25:12 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 23:25:52 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5b88d999fd4590b5ddf1c4223f58e496856c51f0
Cr-Commit-Position: refs/heads/master@{#295597}

Powered by Google App Engine
This is Rietveld 408576698