Use 'display' when creating a shortcut on Android.

Use Manifest.display when creating a shortcut on Android.

The display property will be used only if properly set and
parsed. If used, it will override the signal sent by the
'apple-web-app-capable' and 'mobile-web-app-capable' meta
tags.

This CL is implemented on top of
https://codereview.chromium.org/563083004/

BUG=366145
Committed: https://crrev.com/9317a291b84457b9a8feb8ecd94d0593bb0fff9b
Cr-Commit-Position: refs/heads/master@{#295457}

[mlamouri (slow - plz ping), 2014-09-17 14:36:50]

mlamouri@chromium.org changed reviewers:
+ dfalcantara@chromium.org, miguelg@chromium.org

[gone, 2014-09-17 17:11:24]

https://codereview.chromium.org/576153002/diff/1/chrome/browser/android/short...
File chrome/browser/android/shortcut_helper.cc (right):

https://codereview.chromium.org/576153002/diff/1/chrome/browser/android/short...
chrome/browser/android/shortcut_helper.cc:74: if (web_app_info.mobile_capable ==
WebApplicationInfo::MOBILE_CAPABLE ||
didn't this field get renamed to web_app_capable?  if not, still don't think
this field name makes sense.

[mlamouri (slow - plz ping), 2014-09-17 17:16:41]

https://codereview.chromium.org/576153002/diff/1/chrome/browser/android/short...
File chrome/browser/android/shortcut_helper.cc (right):

https://codereview.chromium.org/576153002/diff/1/chrome/browser/android/short...
chrome/browser/android/shortcut_helper.cc:74: if (web_app_info.mobile_capable ==
WebApplicationInfo::MOBILE_CAPABLE ||
On 2014/09/17 17:11:24, dfalcantara wrote:
> didn't this field get renamed to web_app_capable?  if not, still don't think
> this field name makes sense.

When you asked me to rename, I assumed that you meant for the variable (that was
web_app_capable_ but which is removed by that CL).

It make sense to insist on the web part and less the mobile part in the context
of ShortcutHelper but WebApplicationInfo isn't mobile specific (it's being used
by Chrome Apps for example) so I think mobile_capable is a better name given
that the "web" part is kind of assumed (it's part of WebApplicationInfo...).

[gone, 2014-09-17 17:23:45]

Eh, alright.  lgtm.

[Bernhard Bauer, 2014-09-17 17:51:09]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2014-09-17 17:51:09]

LGTM with a nit:

https://codereview.chromium.org/576153002/diff/1/chrome/browser/android/short...
File chrome/browser/android/shortcut_helper.cc (right):

https://codereview.chromium.org/576153002/diff/1/chrome/browser/android/short...
chrome/browser/android/shortcut_helper.cc:93: default:
You can leave out the default statement; the compiler will complain if you're
missing a value (and that way it will complain if a new value is added, but you
forget to update this place!).

[mlamouri (slow - plz ping), 2014-09-18 09:47:45]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-09-18 09:48:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/576153002/20001

[commit-bot: I haz the power, 2014-09-18 11:49:16]

Committed patchset #2 (id:20001) as 37e498c71ecdd1da21cdcf3402064db658e4cfa3

[commit-bot: I haz the power, 2014-09-18 11:50:12]

Patchset 2 (id:??) landed as
https://crrev.com/9317a291b84457b9a8feb8ecd94d0593bb0fff9b
Cr-Commit-Position: refs/heads/master@{#295457}