Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 576153002: Use 'display' when creating a shortcut on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manifest_parser_stuff
Patch Set: review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index 3a4fb6bf397fb23501f8946b3de8616d6b1a167c..099293f295dea5eb0669fd334e31386cd9bcea87 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -13,10 +13,10 @@
#include "chrome/common/web_application_info.h"
#include "components/favicon_base/favicon_types.h"
#include "content/public/browser/web_contents_observer.h"
+#include "content/public/common/manifest.h"
namespace content {
class WebContents;
-struct Manifest;
} // namespace content
namespace IPC {
@@ -68,7 +68,7 @@ class ShortcutHelper : public content::WebContentsObserver {
static void AddShortcutInBackground(
const GURL& url,
const base::string16& title,
- WebApplicationInfo::MobileCapable mobile_capable,
+ content::Manifest::DisplayMode display,
const favicon_base::FaviconRawBitmapResult& bitmap_result);
// Registers JNI hooks.
@@ -84,7 +84,7 @@ class ShortcutHelper : public content::WebContentsObserver {
GURL url_;
base::string16 title_;
int launcher_large_icon_size_;
- WebApplicationInfo::MobileCapable web_app_capable_;
+ content::Manifest::DisplayMode display_;
favicon_base::FaviconRawBitmapResult icon_;
base::CancelableTaskTracker cancelable_task_tracker_;
« no previous file with comments | « no previous file | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698