Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 576053002: [Nit] Renaming GenerateDashBoard to a more class sounding name DashBoardGenerator (Closed)

Created:
6 years, 3 months ago by patro
Modified:
6 years, 3 months ago
Reviewers:
Dirk Pranke, vivekg
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[Nit] Renaming GenerateDashBoard to a more class sounding name DashBoardGenerator Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
patro
Kindly Review Thanks, Shyam Patro
6 years, 3 months ago (2014-09-17 08:16:47 UTC) #2
Dirk Pranke
lgtm
6 years, 3 months ago (2014-09-17 15:20:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576053002/1
6 years, 3 months ago (2014-09-17 15:50:02 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 16:53:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182167

Powered by Google App Engine
This is Rietveld 408576698