Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py

Issue 576053002: [Nit] Renaming GenerateDashBoard to a more class sounding name DashBoardGenerator (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2014 Google Inc. All rights reserved. 1 # Copyright (C) 2014 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 json_object.clear() 79 json_object.clear()
80 self._add_archived_result(json_object, row) 80 self._add_archived_result(json_object, row)
81 return 81 return
82 82
83 def generate_archived_result(self): 83 def generate_archived_result(self):
84 for key in self._current_result_json_dict["tests"]: 84 for key in self._current_result_json_dict["tests"]:
85 self._process_json_object(self._current_result_json_dict["tests"][ke y], [key]) 85 self._process_json_object(self._current_result_json_dict["tests"][ke y], [key])
86 return self._current_result_json_dict 86 return self._current_result_json_dict
87 87
88 88
89 class GenerateDashBoard(object): 89 class DashBoardGenerator(object):
90 90
91 def __init__(self, port): 91 def __init__(self, port):
92 self._port = port 92 self._port = port
93 self._filesystem = port.host.filesystem 93 self._filesystem = port.host.filesystem
94 self._results_directory = self._port.results_directory() 94 self._results_directory = self._port.results_directory()
95 self._results_directory_path = self._filesystem.dirname(self._results_di rectory) 95 self._results_directory_path = self._filesystem.dirname(self._results_di rectory)
96 self._current_result_json_dict = {} 96 self._current_result_json_dict = {}
97 self._old_failing_results_list = [] 97 self._old_failing_results_list = []
98 self._old_full_results_list = [] 98 self._old_full_results_list = []
99 self._final_result = [] 99 self._final_result = []
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 self._initialize() 147 self._initialize()
148 148
149 # There must be atleast one archived result to be processed 149 # There must be atleast one archived result to be processed
150 if self._current_result_json_dict: 150 if self._current_result_json_dict:
151 process_json_data = ProcessJsonData(self._current_result_json_dict, self._old_failing_results_list, self._old_full_results_list) 151 process_json_data = ProcessJsonData(self._current_result_json_dict, self._old_failing_results_list, self._old_full_results_list)
152 self._final_result = process_json_data.generate_archived_result() 152 self._final_result = process_json_data.generate_archived_result()
153 final_json = json.dumps(self._final_result) 153 final_json = json.dumps(self._final_result)
154 final_json = 'ADD_RESULTS(' + final_json + ');' 154 final_json = 'ADD_RESULTS(' + final_json + ');'
155 with self._filesystem.open_text_file_for_writing(self._filesystem.jo in(self._results_directory, 'archived_results.json')) as file: 155 with self._filesystem.open_text_file_for_writing(self._filesystem.jo in(self._results_directory, 'archived_results.json')) as file:
156 file.write(final_json) 156 file.write(final_json)
OLDNEW
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698