Run gyp_flag_compare.py on Linux GN bots

Run gyp_flag_compare.py on Linux GN bots

Doesn't cause a build failure yet, just generates a log.

R=dpranke@chromium.org
BUG=335824
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291985

[Dirk Pranke, 2014-09-16 18:57:10]

https://codereview.chromium.org/575733003/diff/1/scripts/slave/recipe_modules...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/575733003/diff/1/scripts/slave/recipe_modules...
scripts/slave/recipe_modules/chromium/config.py:84: gn_gyp_compare =
Single(bool, empty_val=False, required=False)
Are you thinking that this eventually becomes something other than a bool ?
Using a config just to indicate whether to run the step or not seems a little
convoluted to me.

[scottmg, 2014-09-16 18:59:20]

https://codereview.chromium.org/575733003/diff/1/scripts/slave/recipe_modules...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/575733003/diff/1/scripts/slave/recipe_modules...
scripts/slave/recipe_modules/chromium/config.py:84: gn_gyp_compare =
Single(bool, empty_val=False, required=False)
On 2014/09/16 18:57:10, Dirk Pranke wrote:
> Are you thinking that this eventually becomes something other than a bool ?
> Using a config just to indicate whether to run the step or not seems a little
> convoluted to me.

Nope, not at all, I'm just lost in the magicness of recipes. How should I pass
from the "Linux GN" dict that I want to run that step?

[Dirk Pranke, 2014-09-16 19:09:18]

Yeah, that's quite understandable. Here's how I would probably do this:

https://codereview.chromium.org/575733003/diff/1/scripts/slave/recipes/chromi...
File scripts/slave/recipes/chromium_gn.py (right):

https://codereview.chromium.org/575733003/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_gn.py:76: 'chromium_apply_config':
['gn_gyp_compare'],
I would change this to 'should_run_gn_gyp_compare': True

https://codereview.chromium.org/575733003/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_gn.py:82: 'chromium_apply_config':
['gn_component_build', 'gn_gyp_compare'],
and do the same thing here.

https://codereview.chromium.org/575733003/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_gn.py:197: if api.chromium.c.gn_gyp_compare:
And then change this to 'if bot_config.get('should_run_gn_gyp_compare', False):

Technically, you probably don't need the ', False' part, but I'd probably put it
in to be a little more explicit.

[scottmg, 2014-09-16 19:21:34]

Thanks! (I find it difficult to discern what's in scope and what's been added to
context objects in which locations)

https://codereview.chromium.org/575733003/diff/1/scripts/slave/recipes/chromi...
File scripts/slave/recipes/chromium_gn.py (right):

https://codereview.chromium.org/575733003/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_gn.py:197: if api.chromium.c.gn_gyp_compare:
On 2014/09/16 19:09:18, Dirk Pranke wrote:
> And then change this to 'if bot_config.get('should_run_gn_gyp_compare',
False):
> 
> Technically, you probably don't need the ', False' part, but I'd probably put
it
> in to be a little more explicit.

Ah, much better, thanks.

[Dirk Pranke, 2014-09-16 19:22:39]

lgtm

[scottmg, 2014-09-16 19:54:09]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-09-16 19:54:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/575733003/40001

[commit-bot: I haz the power, 2014-09-16 19:55:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 19:55:36]

Presubmit check for 575733003-40001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
scripts/tools/blink_roller/auto_roll_test.py (1.30s) failed
Traceback (most recent call last):
  File "scripts/tools/blink_roller/auto_roll_test.py", line 10, in <module>
    import auto_roll
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/tools/blink_roller/auto_roll.py",
line 132, in <module>
    class AutoRoller(object):
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/tools/blink_roller/auto_roll.py",
line 144, in AutoRoller
    'revlog_url': '.+',
TypeError: not enough arguments for format string


Presubmit checks took 60.0s to calculate.

[scottmg, 2014-09-16 19:57:52]

On 2014/09/16 19:55:36, I haz the power (commit-bot) wrote:
> Presubmit check for 575733003-40001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> scripts/tools/blink_roller/auto_roll_test.py (1.30s) failed
> Traceback (most recent call last):
>   File "scripts/tools/blink_roller/auto_roll_test.py", line 10, in <module>
>     import auto_roll
>   File
>
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/tools/blink_roller/auto_roll.py",
> line 132, in <module>
>     class AutoRoller(object):
>   File
>
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/tools/blink_roller/auto_roll.py",
> line 144, in AutoRoller
>     'revlog_url': '.+',
> TypeError: not enough arguments for format string
> 
> 
> Presubmit checks took 60.0s to calculate.

Um... "4".

[scottmg, 2014-09-16 19:58:15]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-09-16 19:58:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/575733003/40001

[commit-bot: I haz the power, 2014-09-16 19:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 19:59:34]

Presubmit check for 575733003-40001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
scripts/tools/blink_roller/auto_roll_test.py (0.44s) failed
Traceback (most recent call last):
  File "scripts/tools/blink_roller/auto_roll_test.py", line 10, in <module>
    import auto_roll
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/tools/blink_roller/auto_roll.py",
line 132, in <module>
    class AutoRoller(object):
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/tools/blink_roller/auto_roll.py",
line 144, in AutoRoller
    'revlog_url': '.+',
TypeError: not enough arguments for format string


Presubmit checks took 53.6s to calculate.

[scottmg, 2014-09-16 20:12:03]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-09-16 20:12:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/575733003/40001

[commit-bot: I haz the power, 2014-09-16 20:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 20:13:47]

Presubmit check for 575733003-40001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
scripts/tools/blink_roller/auto_roll_test.py (0.75s) failed
Traceback (most recent call last):
  File "scripts/tools/blink_roller/auto_roll_test.py", line 10, in <module>
    import auto_roll
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/tools/blink_roller/auto_roll.py",
line 132, in <module>
    class AutoRoller(object):
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/tools/blink_roller/auto_roll.py",
line 144, in AutoRoller
    'revlog_url': '.+',
TypeError: not enough arguments for format string


Presubmit checks took 54.9s to calculate.

[scottmg, 2014-09-16 21:22:31]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-09-16 21:23:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/575733003/40001

[commit-bot: I haz the power, 2014-09-16 21:25:13]

Committed patchset #3 (id:40001) as 291985