Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: scripts/slave/recipes/chromium_gn.py

Issue 575733003: Run gyp_flag_compare.py on Linux GN bots (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: ws Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_gn.py
diff --git a/scripts/slave/recipes/chromium_gn.py b/scripts/slave/recipes/chromium_gn.py
index 120da6f356dd2df22c8cc2eee0ce8008c0e82e60..430639e28c5e64cd99a2848ebb34afea86625887 100644
--- a/scripts/slave/recipes/chromium_gn.py
+++ b/scripts/slave/recipes/chromium_gn.py
@@ -73,12 +73,14 @@ BUILDERS = {
'chromium_config_kwargs': {
'BUILD_CONFIG': 'Release',
},
+ 'should_run_gn_gyp_compare': True,
},
'Linux GN (dbg)': {
'chromium_config_kwargs': {
'BUILD_CONFIG': 'Debug',
},
'chromium_apply_config': ['gn_component_build'],
+ 'should_run_gn_gyp_compare': True,
},
},
},
@@ -193,6 +195,9 @@ def GenSteps(api):
api.chromium.compile(targets=['all'])
+ if bot_config.get('should_run_gn_gyp_compare', False):
+ api.chromium.run_gn_compare()
+
# TODO(dpranke): crbug.com/353854. Run gn_unittests and other tests
# when they are also being run as part of the try jobs.

Powered by Google App Engine
This is Rietveld 408576698