Issue 575613002: Issue 19697. Partial fix - don't search for subclasss members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 575613002: Issue 19697. Partial fix - don't search for subclasss members. (Closed)

Created:
6 years, 3 months ago by scheglov

Modified:
6 years, 3 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 19697. Partial fix - don't search for subclasss members. I think it still worth to commit this CL, if nothing else, it makes search a little faster by not searching for subclasses. R=paulberry@google.com BUG= https://code.google.com/p/dart/issues/detail?id=19697 Committed: https://code.google.com/p/dart/source/detail?r=40290

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+202 lines, -52 lines)			Patch
M	pkg/analysis_server/lib/src/search/element_references.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/search/hierarchy.dart	View	3 chunks	+22 lines, -10 lines	0 comments	Download
M	pkg/analysis_server/test/search/element_references_test.dart	View	1 chunk	+113 lines, -24 lines	1 comment	Download
M	pkg/analysis_server/test/services/search/hierarchy_test.dart	View	5 chunks	+64 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

lgtm https://codereview.chromium.org/575613002/diff/1/pkg/analysis_server/test/search/element_references_test.dart File pkg/analysis_server/test/search/element_references_test.dart (right): https://codereview.chromium.org/575613002/diff/1/pkg/analysis_server/test/search/element_references_test.dart#newcode320 pkg/analysis_server/test/search/element_references_test.dart:320: // test that https://code.google.com/p/dart/issues/detail?id=19697 I'm having trouble understanding ...

6 years, 3 months ago (2014-09-15 21:55:39 UTC) #2

scheglov

6 years, 3 months ago (2014-09-15 23:34:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40290 (presubmit successful).

Expand Messages | Collapse Messages