pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart - Issue 575613002: Issue 19697. Partial fix - don't search for subclasss members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

Issue 575613002: Issue 19697. Partial fix - don't search for subclasss members. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/search/element_references.dart ('k') | pkg/analysis_server/lib/src/services/search/hierarchy.dart » ('j') | pkg/analysis_server/test/search/element_references_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

index a2a143deed7eef5c1be8bc38a6ef854eb68b2851..94919309425e95c5fc1b0dd49f1b870400a9eaf9 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

@@ -238,7 +238,8 @@ class _ClassMemberValidator {

if (element is ClassMemberElement) {

return getHierarchyMembers(

searchEngine,

- element).then((Set<Element> elements) {

+ element,

+ false).then((Set<Element> elements) {

this.elements = elements;

});

} else {