ui/file_manager/image_loader/image_loader_client.js - Issue 575313004: Compiling file_manager, part 2: remove all warnings not caused by Object.freeze()-like enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/image_loader/image_loader_client.js

Issue 575313004: Compiling file_manager, part 2: remove all warnings not caused by Object.freeze()-like enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_file_manager

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/file_manager/file_manager/foreground/js/thumbnail_loader.js ('K') | « ui/file_manager/file_manager/foreground/js/ui/preview_panel.js ('k') | ui/webui/resources/js/cr/ui/dialogs.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/image_loader/image_loader_client.js

diff --git a/ui/file_manager/image_loader/image_loader_client.js b/ui/file_manager/image_loader/image_loader_client.js

index 5876e20d375a14eb96fa0262f61f5bca38c9c516..ae01bb8acb4dd9cc55e3055761c81d493f414dd5 100644

--- a/ui/file_manager/image_loader/image_loader_client.js

+++ b/ui/file_manager/image_loader/image_loader_client.js

@@ -123,7 +123,7 @@ ImageLoaderClient.prototype.handleMessage_ = function(message) {

* @param {function} callback Callback used to return response.

* @param {Object=} opt_options Loader options, such as: scale, maxHeight,

* width, height and/or cache.

- * @param {function=} opt_isValid Function returning false in case

+ * @param {Function=} opt_isValid Function returning false in case

fukino 2014/09/22 06:05:57 More specifically, could you annotate this param a

Vitaly Pavlenko 2014/09/22 20:10:18 Done.

* a request is not valid anymore, eg. parent node has been detached.

* @return {?number} Remote task id or null if loaded from cache.