ui/file_manager/file_manager/foreground/js/thumbnail_loader.js - Issue 575313004: Compiling file_manager, part 2: remove all warnings not caused by Object.freeze()-like enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/thumbnail_loader.js

Issue 575313004: Compiling file_manager, part 2: remove all warnings not caused by Object.freeze()-like enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_file_manager

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/folder_shortcuts_data_model.js ('k') | ui/file_manager/file_manager/foreground/js/ui/file_manager_dialog_base.js » ('j') | ui/file_manager/image_loader/image_loader_client.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/thumbnail_loader.js

diff --git a/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js b/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js

index 3077c0eaf015ac193397fd14a0b151747c3342b6..6b19346f0a8aa15cc53def1030bcefbc728548ce 100644

--- a/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js

+++ b/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js

@@ -136,8 +136,8 @@ ThumbnailLoader.THUMBNAIL_MAX_HEIGHT = 500;

* for downloading thumbnails. By default optimizations are disabled.

* @param {function(Image, Object)=} opt_onSuccess Success callback,

* accepts the image and the transform.

- * @param {function=} opt_onError Error callback.

- * @param {function=} opt_onGeneric Callback for generic image used.

+ * @param {Function=} opt_onError Error callback.

fukino 2014/09/22 06:05:57 {function()=} looks more consistent with annotatio

Vitaly Pavlenko 2014/09/22 20:10:18 Done.

+ * @param {Function=} opt_onGeneric Callback for generic image used.

fukino 2014/09/22 06:05:57 ditto

Vitaly Pavlenko 2014/09/22 20:10:18 Done.

ThumbnailLoader.prototype.load = function(box, fillMode, opt_optimizationMode,

opt_onSuccess, opt_onError, opt_onGeneric) {