Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 575293003: Fix threading issue in StreamTextureProxyImpl (Closed)

Created:
4 years, 11 months ago by boliu
Modified:
4 years, 11 months ago
Reviewers:
qinmin, no sievers
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix threading issue in StreamTextureProxyImpl BindToLoop need to set |loop_| synchronously to prevent delete from destroying the object on the wrong thread. BUG=415306, 412578 Committed: https://crrev.com/c8072c10dd733f38c7f429333b85dc63383597ef Cr-Commit-Position: refs/heads/master@{#295543}

Patch Set 1 #

Total comments: 3

Patch Set 2 : no lock #

Total comments: 9

Patch Set 3 : review, comment only changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -49 lines) Patch
M content/renderer/media/android/stream_texture_factory_impl.cc View 1 2 3 chunks +26 lines, -24 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory_synchronous_impl.cc View 1 2 5 chunks +26 lines, -25 lines 0 comments Download

Messages

Total messages: 17 (2 generated)
boliu
PTAL asap please. This context lost fix has dragged on for 2+weeks.
4 years, 11 months ago (2014-09-18 01:43:52 UTC) #2
qinmin
https://codereview.chromium.org/575293003/diff/1/content/renderer/media/android/stream_texture_factory_impl.cc File content/renderer/media/android/stream_texture_factory_impl.cc (right): https://codereview.chromium.org/575293003/diff/1/content/renderer/media/android/stream_texture_factory_impl.cc#newcode52 content/renderer/media/android/stream_texture_factory_impl.cc:52: scoped_refptr<base::MessageLoopProxy> loop; why do we need this, cannot we ...
4 years, 11 months ago (2014-09-18 02:01:31 UTC) #3
boliu
https://codereview.chromium.org/575293003/diff/1/content/renderer/media/android/stream_texture_factory_impl.cc File content/renderer/media/android/stream_texture_factory_impl.cc (right): https://codereview.chromium.org/575293003/diff/1/content/renderer/media/android/stream_texture_factory_impl.cc#newcode52 content/renderer/media/android/stream_texture_factory_impl.cc:52: scoped_refptr<base::MessageLoopProxy> loop; On 2014/09/18 02:01:30, qinmin wrote: > why ...
4 years, 11 months ago (2014-09-18 02:04:23 UTC) #4
boliu
Ehh, whatever, removed that lock on loop
4 years, 11 months ago (2014-09-18 02:14:23 UTC) #5
qinmin
lgtm
4 years, 11 months ago (2014-09-18 02:22:07 UTC) #6
boliu
On 2014/09/18 02:22:07, qinmin wrote: > lgtm I'll wait for Daniel too
4 years, 11 months ago (2014-09-18 02:23:36 UTC) #7
qinmin
https://codereview.chromium.org/575293003/diff/20001/content/renderer/media/android/stream_texture_factory_impl.cc File content/renderer/media/android/stream_texture_factory_impl.cc (right): https://codereview.chromium.org/575293003/diff/20001/content/renderer/media/android/stream_texture_factory_impl.cc#newcode68 content/renderer/media/android/stream_texture_factory_impl.cc:68: DCHECK(loop); loop is not always non-null. For Layout tests, ...
4 years, 11 months ago (2014-09-18 16:45:11 UTC) #8
boliu
bug?
4 years, 11 months ago (2014-09-18 16:46:28 UTC) #9
boliu
On 2014/09/18 16:46:28, boliu wrote: > bug? I mean is there a bug number?
4 years, 11 months ago (2014-09-18 16:47:26 UTC) #10
qinmin
On 2014/09/18 16:46:28, boliu wrote: > bug? Probably layout test is not running threaded compositing ...
4 years, 11 months ago (2014-09-18 16:47:39 UTC) #11
no sievers
lgtm https://codereview.chromium.org/575293003/diff/20001/content/renderer/media/android/stream_texture_factory_impl.cc File content/renderer/media/android/stream_texture_factory_impl.cc (right): https://codereview.chromium.org/575293003/diff/20001/content/renderer/media/android/stream_texture_factory_impl.cc#newcode39 content/renderer/media/android/stream_texture_factory_impl.cc:39: base::Lock lock_; nit: put a comment 'protects access ...
4 years, 11 months ago (2014-09-18 18:46:53 UTC) #12
boliu
https://codereview.chromium.org/575293003/diff/20001/content/renderer/media/android/stream_texture_factory_impl.cc File content/renderer/media/android/stream_texture_factory_impl.cc (right): https://codereview.chromium.org/575293003/diff/20001/content/renderer/media/android/stream_texture_factory_impl.cc#newcode39 content/renderer/media/android/stream_texture_factory_impl.cc:39: base::Lock lock_; On 2014/09/18 18:46:53, sievers wrote: > nit: ...
4 years, 11 months ago (2014-09-18 19:15:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575293003/40001
4 years, 11 months ago (2014-09-18 19:16:44 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as b4fd97206c57cd2347d6e2997b5f0d9db6fefda1
4 years, 11 months ago (2014-09-18 20:19:21 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2014-09-18 20:19:51 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c8072c10dd733f38c7f429333b85dc63383597ef
Cr-Commit-Position: refs/heads/master@{#295543}

Powered by Google App Engine
This is Rietveld 408576698