Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: content/browser/media/webrtc_internals.cc

Issue 575283004: Change WebRTCInternals::GetInstance() to use a leaky LazyInstance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/webrtc_internals.cc
diff --git a/content/browser/media/webrtc_internals.cc b/content/browser/media/webrtc_internals.cc
index 92ca83cc2f4b393dc81e0123d6a648cb10ddae7a..51c19cb84db346a96cff5f59cb26a92bb86a6e98 100644
--- a/content/browser/media/webrtc_internals.cc
+++ b/content/browser/media/webrtc_internals.cc
@@ -61,7 +61,8 @@ WebRTCInternals::~WebRTCInternals() {
}
WebRTCInternals* WebRTCInternals::GetInstance() {
- return Singleton<WebRTCInternals>::get();
+ return Singleton<WebRTCInternals,
DaleCurtis 2014/09/19 01:05:55 Hmm, this seems like it should be a leaky LazyInst
tommi (sloooow) - chröme 2014/09/19 01:28:42 Do you mean to create a static variable instead? (
DaleCurtis 2014/09/19 02:27:57 We typically prefer LazyInstance to Singleton. Or
+ LeakySingletonTraits<WebRTCInternals> >::get();
}
void WebRTCInternals::OnAddPeerConnection(int render_process_id,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698