Change WebRTCInternals::GetInstance() to use a leaky LazyInstance.

content/browser/media/webrtc_internals.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/webrtc_internals.h"
 
 #include "base/path_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "content/browser/media/webrtc_internals_ui_observer.h"
 #include "content/browser/web_contents/web_contents_view.h"
@@ skipping 43 matching lines @@
     aec_dump_file_path_ =
         aec_dump_file_path_.Append(FILE_PATH_LITERAL("audio.aecdump"));
   }
 #endif  // defined(ENABLE_WEBRTC)
 }
 
 WebRTCInternals::~WebRTCInternals() {
 }
 
 WebRTCInternals* WebRTCInternals::GetInstance() {
-  return Singleton<WebRTCInternals>::get();
+  return Singleton<WebRTCInternals,

[DaleCurtis, 2014/09/19 01:05:55]

Hmm, this seems like it should be a leaky LazyInstance instead.

[tommi (sloooow) - chröme, 2014/09/19 01:28:42]

Do you mean to create a static variable instead?
(I'm a bit slow at the moment so sorry if this is obvious - perhaps you just
need to spell it out to me :))

[DaleCurtis, 2014/09/19 02:27:57]

We typically  prefer LazyInstance to Singleton. Or so says  the Singleton header
:)

+                   LeakySingletonTraits<WebRTCInternals> >::get();
 }
 
 void WebRTCInternals::OnAddPeerConnection(int render_process_id,
                                           ProcessId pid,
                                           int lid,
                                           const string& url,
                                           const string& rtc_configuration,
                                           const string& constraints) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
@@ skipping 299 matching lines @@
   } else if (!peer_connection_data_.empty() && !power_save_blocker_) {
     DVLOG(1) << ("Preventing the application from being suspended while one or "
                  "more PeerConnections are active.");
     power_save_blocker_ = content::PowerSaveBlocker::Create(
         content::PowerSaveBlocker::kPowerSaveBlockPreventAppSuspension,
         "WebRTC has active PeerConnections.").Pass();
   }
 }
 
 }  // namespace content