Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 57513004: Profile chooser bubble overlaps avatar button and shouldn't. (Closed)

Created:
7 years, 1 month ago by noms (inactive)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Profile chooser bubble overlaps avatar button and shouldn't. There was a change in BubbleBorder (https://codereview.chromium.org/53703002) that removed the 10px insets on the border, so we no longer need to compensate for them. BUG=NONE TEST=With --new-profile-management enabled, click on the avatar button. The bubble should show up just below it. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/ui/views/profile_chooser_view.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
noms (inactive)
Hi Peter, Super tiny CL adjusting for a change in the BubbleBorder bounds. Please take ...
7 years, 1 month ago (2013-11-04 22:19:38 UTC) #1
Peter Kasting
LGTM
7 years, 1 month ago (2013-11-04 22:22:16 UTC) #2
noms (inactive)
Thanks! On 2013/11/04 22:22:16, Peter Kasting wrote: > LGTM
7 years, 1 month ago (2013-11-04 22:23:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/57513004/1
7 years, 1 month ago (2013-11-04 22:50:11 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184566
7 years, 1 month ago (2013-11-05 02:35:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/57513004/1
7 years, 1 month ago (2013-11-05 04:03:49 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 07:24:28 UTC) #7
Message was sent while issue was closed.
Change committed as 232943

Powered by Google App Engine
This is Rietveld 408576698