Issue 53703002: Remove IDR_BUBBLE_SHADOW, use IDR_WINDOW_BUBBLE_SHADOW_BIG.

Issue 53703002: Remove IDR_BUBBLE_SHADOW, use IDR_WINDOW_BUBBLE_SHADOW_BIG. (Closed)

Created:
7 years, 1 month ago by msw

Modified:
7 years, 1 month ago

Reviewers:
oshima, yzshen1, sky, scheib

CC:
chromium-reviews, tfarina, alicet1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove IDR_BUBBLE_SHADOW, use IDR_WINDOW_BUBBLE_SHADOW_BIG. Remove the IDRs, asset files, and example usage. These assets were only used for the fullscreen bubble. Use some highly similar and more common assets instead. Tweak its padding to accommodate slightly larger assets. See before/after at: http://crbug.com/181257#c14 BUG=181257, 313400 TEST=Fullscreen bubble looks slightly different, no other change. R=sky@chromium.org,yzshen@chromium.org,oshima@chromium.org,scheib@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232085

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -33 lines)			Patch
M	chrome/browser/ui/fullscreen/fullscreen_exit_bubble.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/fullscreen_exit_bubble_views.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
D	ui/resources/default_100_percent/bubble_shadow_bottom.png	View	Binary file		0 comments	Download
D	ui/resources/default_100_percent/bubble_shadow_bottom_left.png	View	Binary file		0 comments	Download
D	ui/resources/default_100_percent/bubble_shadow_bottom_right.png	View	Binary file		0 comments	Download
D	ui/resources/default_100_percent/bubble_shadow_left.png	View	Binary file		0 comments	Download
D	ui/resources/default_100_percent/bubble_shadow_right.png	View	Binary file		0 comments	Download
D	ui/resources/default_100_percent/bubble_shadow_top.png	View	Binary file		0 comments	Download
D	ui/resources/default_100_percent/bubble_shadow_top_left.png	View	Binary file		0 comments	Download
D	ui/resources/default_100_percent/bubble_shadow_top_right.png	View	Binary file		0 comments	Download
M	ui/resources/ui_resources.grd	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	ui/views/bubble/bubble_border.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/views/bubble/bubble_border.cc	View	3 chunks	+0 lines, -15 lines	0 comments	Download
M	ui/views/examples/bubble_example.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/examples/bubble_example.cc	View	2 chunks	+1 line, -5 lines	0 comments	Download

Total messages: 9 (0 generated)

msw

Hey Scott, Oshima, and Yuzhu, please take a look; thanks! Scott: ui/views/* and c/b/ui/views/* Yuzhu: ...

7 years, 1 month ago (2013-10-31 00:03:31 UTC) #1

yzshen1

On 2013/10/31 00:03:31, msw wrote: > Hey Scott, Oshima, and Yuzhu, please take a look; ...

7 years, 1 month ago (2013-10-31 00:07:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/53703002/170001

7 years, 1 month ago (2013-10-31 02:01:39 UTC) #6

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 1 month ago (2013-10-31 03:06:50 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/53703002/170001

7 years, 1 month ago (2013-10-31 03:11:28 UTC) #8

Message was sent while issue was closed.

Change committed as 232085