Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: Source/core/css/CSSParser-in.cpp

Issue 57493002: Remove 'alphabetic' value from text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSParser-in.cpp
diff --git a/Source/core/css/CSSParser-in.cpp b/Source/core/css/CSSParser-in.cpp
index 3c6d96295263769ae0f4352ca4deff86249ec343..0eb6b090ef03304d54efc9b6f834f83220f072c7 100644
--- a/Source/core/css/CSSParser-in.cpp
+++ b/Source/core/css/CSSParser-in.cpp
@@ -2183,7 +2183,7 @@ bool CSSParser::parseValue(CSSPropertyID propId, bool important)
break;
case CSSPropertyTextUnderlinePosition:
- // auto | alphabetic | under
+ // auto | under | inherit
if (RuntimeEnabledFeatures::css3TextDecorationsEnabled())
return parseTextUnderlinePosition(important);
return false;
@@ -9135,13 +9135,12 @@ bool CSSParser::parseTextDecoration(CSSPropertyID propId, bool important)
bool CSSParser::parseTextUnderlinePosition(bool important)
{
- // The text-underline-position property has sintax "auto | alphabetic | [ under || [ left | right ] ]".
- // However, values 'left' and 'right' are not implemented yet, so we will parse sintax
- // "auto | alphabetic | under" for now.
+ // The text-underline-position property has syntax "auto | [ under || [ left | right ] ]".
+ // However, values 'left' and 'right' are not implemented yet, so we will parse syntax
+ // "auto | under" for now.
CSSParserValue* value = m_valueList->current();
switch (value->id) {
case CSSValueAuto:
- case CSSValueAlphabetic:
case CSSValueUnder:
if (m_valueList->next())
return false;

Powered by Google App Engine
This is Rietveld 408576698