Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(189)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: LayoutTests/platform/win/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png
Issue
57493002
:
Remove 'alphabetic' value from text-underline-position (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing
Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
LayoutTests/TestExpectations
LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt
LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js
LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/style.css
LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html
LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.txt
LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html
LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.txt
LayoutTests/platform/linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png
LayoutTests/platform/mac/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png
LayoutTests/platform/win/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png
Source/core/css/CSSParser-in.cpp
Source/core/css/CSSPrimitiveValueMappings.h
Source/core/rendering/InlineTextBox.cpp
Source/core/rendering/style/RenderStyleConstants.h
Source/core/rendering/style/StyleRareInheritedData.h
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« LayoutTests/platform/mac/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png
('k') |
Source/core/css/CSSParser-in.cpp »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
« no previous file with comments
|
« LayoutTests/platform/mac/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png
('k') |
Source/core/css/CSSParser-in.cpp »
('j') |
no next file with comments »
Issue 57493002: Remove 'alphabetic' value from text-underline-position (Closed)
Created 7 years, 1 month ago by abinader
Modified 7 years, 1 month ago
Reviewers: eae, Julien - ping for review
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 17
This is Rietveld
408576698
Chromium Code Reviews
Issue 57493002:
Remove 'alphabetic' value from text-underline-position (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
